Skip to content

Conversation

@artembilan
Copy link
Contributor

@artembilan artembilan commented Oct 23, 2025

  • Provide a KclMessageDrivenChannelAdapter - the MessageProducer implementation to consume data from Kinesis stream using KCL API internally
  • Reorder spring-cloud-aws-kinesis dependencies, since KPL wants a higher protobuf-java version than KCL provides
  • Mark KplKclIntegrationTests as @DisabledOnOs(OS.WINDOWS) since KPL does not provide Windows native library anymore
  • Add spring-cloud-aws-starter-integration-kinesis-client
  • Document the feature

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

* Provide a `KclMessageDrivenChannelAdapter` - the `MessageProducer` implementation
to consume data from Kinesis stream using KCL API internally
* Reorder `spring-cloud-aws-kinesis` dependencies, since KPL wants a higher `protobuf-java`
 version than KCL provides
* Mark `KplKclIntegrationTests` as `@DisabledOnOs(OS.WINDOWS)` since KPL does not provide Windows native library anymore
* Add `spring-cloud-aws-starter-integration-kinesis-client`
* Document the feature
@github-actions github-actions bot added type: documentation Documentation or Samples related issue type: dependency-upgrade Dependency version bump labels Oct 23, 2025
* Disable metrics for KCL in the `KplKclIntegrationTests`
* Remove all the `@AfterAll` from Kinesis integration test.
It looks like KCL infrastructure is not done even after a graceful shutdown
* `setCredentialsRefreshDelay(300000L)` for KPL to avoid credentials refresh as much as possible
It fails with:
```
17:24:43.079 [lam-thread] WARN  com.amazonaws.services.dynamodbv2.AmazonDynamoDBLockClient - Could not acquire lock because of a client side failure in talking to DDB
```
Somehow KCL doesn't work well where there is KPL, too
@artembilan
Copy link
Contributor Author

OK. Now it is good for review.
I have KplKclIntegrationTests as disabled since KCL somehow doesn't work well with KPL and Localstack.
I cannot debug it on my Windows since KPL does not provide a native library for that OS anymore.
So, if anyone interested and can do that in debug mode, please, be my guest with improvements in that area.

Thank you!

Copy link
Member

@MatejNedic MatejNedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem looks amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: dependency-upgrade Dependency version bump type: documentation Documentation or Samples related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants