Skip to content

Conversation

@MatejNedic
Copy link
Member

@MatejNedic MatejNedic commented Oct 26, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

@tomazfernandes everything regarding converters I have changed. I am not sure what is best way to tackle JsonMappers since JacksonJsonMessageConverter hides it. There is no way to set only to propagate one when using constructor.
I am tbh not sure what is best action here but it is a breaking change so please look and lets agree how to move. Be free to checkout PR and push directly :)

There are also few tests I have put to ignore till we settle the approach.

I tbh would go that users provide their own converters personally. JsonMapper default one already is registering few modules so yea.

I have to check cloudwatch integration currently it is failing I will check it tomorrow evening.

Also I have to rework docs since a autoconfiguration will prolly change!

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added component: cloudwatch CloudWatch integration related issue component: parameter-store Parameter Store integration related issue component: s3 S3 integration related issue component: secrets-manager Secrets Manager integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue type: dependency-upgrade Dependency version bump component: core Core functionality related issue component: dynamodb DynamoDB integration related issue labels Oct 26, 2025
@MatejNedic MatejNedic self-assigned this Oct 26, 2025
@MatejNedic MatejNedic added this to the 4.0.0 milestone Oct 29, 2025
@tomazfernandes
Copy link
Contributor

Hey @MatejNedic,

I suggest that the project follows the pattern the Spring team did for their migration, in order to support both Jackson v2 and v3 as they do.

The pattern is, roughly:

  • Duplicate all classes that use Jackson v2
  • Adjust the imports in the duplicate to the new v3 namespace
  • Change ObjectMapper usages to JsonMapper in the duplicates

Here's an example with DefaultKafkaHeaderMapper and JsonKafkaHeaderMapper

At some decision points, they check which Jackson versions are in the classpath, such as in MessagingMessageConverter

This is the PR from Spring Kafka's migration for reference: spring-projects/spring-kafka#3996

Let me know if that makes sense to you.

@MatejNedic
Copy link
Member Author

Hey @tomazfernandes

Sounds good to me!

I have seen while moving to jackson 3 Deprecated on top of jackson 2 convrter classes.

Can you make the changes required against this PR? Just check it out and push freely. I sadly won't have time till middle of next week.

@tomazfernandes
Copy link
Contributor

Unfortunately, I won't have the time either. I think it's fine for us to leave this migration for M2. I'll open an issue to track this, so the community can pitch in as well.

@tomazfernandes
Copy link
Contributor

Created the issue: #1511

Feel free to edit if you'd like.

Copy link
Contributor

@tomazfernandes tomazfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold until the work is aligned with the direction the team agreed on.

@MatejNedic
Copy link
Member Author

MatejNedic commented Nov 6, 2025

Lets go with M1 release with Jackson 2 support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: cloudwatch CloudWatch integration related issue component: core Core functionality related issue component: dynamodb DynamoDB integration related issue component: parameter-store Parameter Store integration related issue component: s3 S3 integration related issue component: secrets-manager Secrets Manager integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue type: dependency-upgrade Dependency version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants