Required update to handle new QA4SM netCDF structure according to Jira-744 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing renaming the output files and figure titles accordingly
…ub-window case's name. also, maps are only created fo r the default case
…tead of the watermark
6 tasks
Fix bugs with metadata plots
…f file and enhanced type hints
…enerationwit tcol metrics
implemented saving of created figures in one go for multiple filetypes
…d for temp. sub-win. dimension as additional item in `QA4SMImage.varnames` in `test_image.py::test_load_vars`
…rected for temp. sub-win. dimension as additional item in `QA4SMImage.varnames` in `test_image.py::test_load_vars`
… of the `qa4sm_reader` package, isntead of `qa4sm`. Further, the globals file was adapted accordingly and now contains all vars required. `qa4sm` imports these specific vars then from the `qa4sm_reader.globals` file. Lastly, `qa4sm_reader.img.QA4SMImg` was adapted to check if a dimension corresponding to temporal sub-windows exists in the specified netCDF file and if not automatically transcribes the loaded dataset. Tests were adapted accordingly.
…cmetric_vars()` to exclude TC metric vars of same reference and metric dataset from being plotted
Integration of temporal sub-window logic and QA4SM netCDF transcription as well as adaptation of tests
…clusion of logo as watermark
Tests for intra annual windows
* Update environment.yml checking if defining pyscaffold in the env helps fixing the problem with failing tests * Update CI and dependency list * Update env * Update CI * Update env * Update CI --------- Co-authored-by: Wolfgang Preimesberger <[email protected]>
Master tmp
wpreimes
added a commit
that referenced
this pull request
Oct 10, 2024
…a-744 (#77) (#83) * intial * started adapting * adapted existing code to properly handle temporal sub-windows, including renaming the output files and figure titles accordingly * before testing * fig titles and filenames now always contain the default or temporal sub-window case's name. also, maps are only created fo r the default case * intermediate saving * added all code required to generate comparison boxplots * fully integrated compariosn plots and all plots now have the logo instead of the watermark * all statistics .csv files are now stroed in a dedicated zip archive * intermediate commit * Fix bugs with metadata plots * automatic extraction of temporal sub-window names from provided netcdf file and enhanced type hints * testing of tcol metrics plotting * removed debugging statements, implemented bug fix for metadata plot generationwit tcol metrics * comparison boxplots of tcol metrics are not created * implemented saving of created figures in one go for multiple filetypes * code for netcdf file transcription to new qa4sm nc structure * removed accidentally staged restructured files * implemented means for transcription for all test files * added automatic netCDF file transcription prior to tests and corrected for temp. sub-win. dimension as additional item in `QA4SMImage.varnames` in `test_image.py::test_load_vars` * pt2: added automatic netCDF file transcription prior to tests and corrected for temp. sub-win. dimension as additional item in `QA4SMImage.varnames` in `test_image.py::test_load_vars` * netcdf_transcription.py and intra_annual_temp_windows.py now are part of the `qa4sm_reader` package, isntead of `qa4sm`. Further, the globals file was adapted accordingly and now contains all vars required. `qa4sm` imports these specific vars then from the `qa4sm_reader.globals` file. Lastly, `qa4sm_reader.img.QA4SMImg` was adapted to check if a dimension corresponding to temporal sub-windows exists in the specified netCDF file and if not automatically transcribes the loaded dataset. Tests were adapted accordingly. * code cleaning. * code cleaning * introduced function `qa4sm_reader.utils.filter_out_self_combination_tcmetric_vars()` to exclude TC metric vars of same reference and metric dataset from being plotted * added pytesmo dependency * added MANIFEST.in to correctly install the static dir requried for inclusion of logo as watermark * deleted superflous files * adapted packaging of reader to incorporat the static dir containing the logo * tests for intra_annual_temp_windows * added tests to test_utils and made sure they run first * started test_netcdf_transcription.py * fixed test_logo_exists * fixing test_keep_pytesmo_ncfile * tests for netcdf_transcription * finished test development for intra annual metrics and adapation of existing tests * Update environment.yml (#81) * Update environment.yml checking if defining pyscaffold in the env helps fixing the problem with failing tests * Update CI and dependency list * Update env * Update CI * Update env * Update CI --------- * added test to check intra-annual metric related plots and proper file transcription * fixed tests/test_netcdf_transcription.py::test_correct_file_transcription * fixed tests/test_netcdf_transcription.py::test_correct_file_transcription * fixed windows test failing * fixed mamba workflow issue * bug fix for obtaining amount of chars from Path object --------- Co-authored-by: Nicolas F. Bader <[email protected]> Co-authored-by: Monika Tercjak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to handle new QA4SM netCDF file structure and provdide new plots for temporal sub-window based metrics
To Do
plotting_methods._dict2df()does not work with tcol metrics and throws error