Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: iterate through all owner objects to find target #336

Closed
wants to merge 1 commit into from

Conversation

sdaveas
Copy link
Contributor

@sdaveas sdaveas commented Aug 14, 2024

getOwnedObjects returns a limited number of objects per page (50 by default), and our target might not be found in the first one. That's why we should iterate through all pages of the result until no next page is found, or we track our target object.

@sdaveas sdaveas requested a review from a team as a code owner August 14, 2024 08:26
@sdaveas sdaveas requested review from milapsheth and canhtrinh and removed request for a team August 14, 2024 08:26
`getOwnedObjects` returns a limited number of objects per page (50 by
default), and our target might not be found in the first one. That's why
we should iterate through all pages of the result until no next page is
found, or we track our target object.
@sdaveas sdaveas force-pushed the stelios/feat/sui-operators branch from 269cbdd to 7175992 Compare August 14, 2024 08:49
@npty
Copy link
Member

npty commented Aug 14, 2024

Thank you for the PR @sdaveas 🙏🏻

I'll close this PR since I will utilize the paginateAll function in this PR instead.

@npty npty closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants