feat(stellar): its example scripts #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milapsheth
reviewed
Jan 7, 2025
stellar/its-example.js
Outdated
| minter, | ||
| ); | ||
|
|
||
| await broadcast(operation, wallet, chain, 'Deploy Token', options); |
There was a problem hiding this comment.
We should change the behaviour to not authorize all invocations by default, and authorize it explicitly.
stellar/its-example.js
Outdated
| .command('deploy-token <symbol> <name> <decimals> <salt> <initialSupply> ') | ||
| .action((symbol, name, decimal, salt, initialSupply, options) => { | ||
| mainProcessor(deployToken, [symbol, name, decimal, salt, initialSupply], options); | ||
| }); |
There was a problem hiding this comment.
also add canonical registration and deployment?
You should do an e2e test for that as well. To register and deploy XLM to Avalanche.
There was a problem hiding this comment.
I'm facing an authorization issue with deployRemoteCanonicalToken. Work in progress.
ahramy
force-pushed
the
feat/add-its-example-scripts
branch
from
726eb06 to
6c65f8a
Compare
milapsheth
reviewed
Jan 14, 2025
| #### Execute | ||
|
|
||
| ```bash | ||
| node stellar/its.js execute [source-chain] [message-id] [source-address] [payload] |
There was a problem hiding this comment.
Suggested change
| node stellar/its.js execute [source-chain] [message-id] [source-address] [payload] | |
| node stellar/gateway.js execute [source-chain] [message-id] [source-address] [payload] |
Move this under gateway section
| @@ -77,6 +78,9 @@ async function buildTransaction(operation, server, wallet, networkType, options | |||
| const prepareTransaction = async (operation, server, wallet, networkType, options = {}) => { | |||
| const builtTransaction = await buildTransaction(operation, server, wallet, networkType, options); | |||
|
|
|||
| // ahram test | |||
| async function setTrustedChain(wallet, _, chain, contractConfig, arg, options) { | ||
| const contract = new Contract(contractConfig.address); | ||
| async function setTrustedChain(wallet, _, chain, arg, options) { | ||
| const contract = new Contract(chain.contracts.interchain_token_service?.address); |
There was a problem hiding this comment.
provide contract as an arg to reduce duplication
| const itsAddressScVal = nativeToScVal(Address.fromString(itsAddress), { type: 'address' }); | ||
| const axlearScVal = nativeToScVal('axelar', { type: 'string' }); | ||
| const axelarAddressScVal = nativeToScVal('axelar13ehuhysn5mqjeaheeuew2gjs785f6k7jm8vfsqg3jhtpkwppcmzqtedxty', { type: 'string' }); | ||
| const payloadHex = |
| await broadcast(operation, wallet, chain, 'Remote Canonical Token Deployed', options); | ||
| } | ||
|
|
||
| // async function deployRemoteCanonicalTokenOrg(wallet, _, chain, args, options) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-7043