Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: interchain token service deployment #83

Merged
merged 17 commits into from
Nov 29, 2023
Merged

feat: interchain token service deployment #83

merged 17 commits into from
Nov 29, 2023

Conversation

Foivos
Copy link
Contributor

@Foivos Foivos commented Jul 21, 2023 •
edited by jira bot
Loading

@Foivos Foivos requested review from npty and re1ro July 21, 2023 09:34
npty
npty reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@npty npty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some tests to make sure the deployment is working as expected?

packages/axelar-local-dev/test.js Outdated Show resolved Hide resolved
npty
npty reviewed Jul 25, 2023
View reviewed changes
packages/axelar-local-dev/src/Network.ts Outdated Show resolved Hide resolved
packages/axelar-local-dev/src/Network.ts Outdated Show resolved Hide resolved
packages/axelar-local-dev/src/its.ts Outdated Show resolved Hide resolved
packages/axelar-local-dev/src/its.ts Show resolved Hide resolved
@npty
Copy link
Member

npty commented Jul 28, 2023

force pushed here to resolve merge conflicts

@raress96
Copy link
Contributor

Hello. Is there a timeline when this will get merged into main branch?

@npty npty self-requested a review November 29, 2023 09:26
@Foivos Foivos merged commit 65a0307 into main Nov 29, 2023
1 check passed
@Foivos Foivos deleted the feat/its branch November 29, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npty npty npty approved these changes

@re1ro re1ro Awaiting requested review from re1ro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Foivos @npty @raress96