Change the default refund address #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functions and move to AxelarQueryAPI
npty
changed the title
npty
requested review from
canhtrinh and
vladwulf
and removed request for
canhtrinh
canhtrinh
approved these changes
Dec 8, 2022
canhtrinh
added a commit
that referenced
this pull request
Jan 18, 2023
* Fix nativeAddGas api doesn't detect gas unpaid correctly (#193) * fix: validate contract event args * chore: fix amount compare * test: add tests for `contractEventHelper` * chore: remove unused import * test: fix failed tests * chore: fix lint * chore: remove all return await * chore: update rpc & lcd uri (#199) * feat: update deposit service integration into getDepositAddress metho… (#196) * feat: update deposit service integration into getDepositAddress method with new object param * chore: incorporating vlad comments * Chain ids (#202) * feat: initial commit for refactor of all methods to use chainId * chore: wip * chore: code cleanup * 0.12.0-alpha * feat: adding 0.12.0 changelogs (#204) * feat: adding 0.12.0 changelogs * chore: update changelog for axelarjs-types * chore: update changelog Co-authored-by: vladwulf <[email protected]> * Fix cannot find chain `ethereum-2` (#206) * fix: cannot find chain name 'ethereum-2' * fix: lint * chore: fix lint * chore: remove as EvmChain as the function signature is string * chore: fix lint * chore/fix undefined assets (#207) chore: fix undefined assetInfo * chore: updating axelarjs-types to v0.27.0 (#205) * Small fixes (#203) * chore: adding refundAddress and shouldUnwrapIntoNative into dto * chore: adding some fixes * 0.12.0-alpha.1 * chore: fix test * Implement getActiveChains query and more (#210) * feat: add query for getActiveChains * chore: implement tests for AxelarQueryAPI * chore: remove isValidChainIdentifier in private function * chore: map to lowercase before returning * feat: add a function to throw if the chain is inactive * chore: rename isValidChainIdentifier -> throwIfInvalidChainId * chore: improve tests performance * feat: add throwIfInactiveChain function for AxelarAssetTransfer * chore: Add jest mock for AxelarAssetTransfer tests to prevent real network calls * chore: removed throwIfInactiveChain in calculateGasFee and calculateNativeGasFee because it already exist in subtractGas function * chore: remove lowercase * Update CHANGELOG.md Co-authored-by: Canh Trinh <[email protected]> * Add chainId suggestion for getTransferFee and more (#211) * feat: refactor duplicated validateChainIdentifiers function * feat: improves perf for chains validation * chore: update function calls due to function signature changed * chore: fix tests * feat: fixed getTransferFee doesn't check for chainId * chore: fix tests * chore: fix lint * chore: use constant * fix integration tests (#212) chore: fix integration tests * Fix/native denom bug (#213) * fix: getERC20Denom should correctly use chainId * chore: tsconfig should include global types * clean: unused await * fix: possible nullable bug * 0.12.0-alpha.2 * fix: tests * Change the default refund address (#217) * chore: refactor getGasReceiverContractAddress by removing duplicated functions and move to AxelarQueryAPI * chore: throw if invalid chain id * chore: refactor `getGasReceiverContractAddress` to `getContractAddressFromConfig` * feat: change the default refundAddress to `default_refund_collector` from config * chore: fix tests * feat: add instruction about valid contractKey * chore: fix wrong contractkey * Add `timeSpent` for `queryTransactionStatus` API (#218) * feat: add `timeSpent` * test: add e2e tests for timeSpent * chore: cleanup unnecessary function * chore: update changelog * chore: revert GMPStatus except the addition values * 0.12.0-alpha.3 * chore: using chain id for getContractAddressFromConfig * 0.12.0-alpha.4 * Adding missing EVMChain and config values (#221) * chore: add-missing-evm-chains * update chains.ts * capitalise kava Co-authored-by: vladwulf <[email protected]> * 0.12.0-alpha.5 * chore: change rpc url for mainnet to worker * 0.12.0-alpha.6 * chore: params for in validateOfflineDepositAddress for unwrap case * 0.12.0-alpha-7 * chore: changing refund address default for unwrap * 0.12.0-alpha-8 * chore: fix test * feat: adding query for token limit on evm chains (#225) * feat: adding query for token limit on evm chains chore: codefix and fixing tests * chore: update getTransferLimit based on new min logic * chore: updating PR to take simple min of limits * chore: code cleanup * chore: code cleanup * chore: dealing with overflow * 0.12.0-alpha.10 * chore: refactor token mint limit * 0.12.0-alpha.11 * chore: code cleanup * 0.12.0-alpha.12 * chore: convert native token to erc in axelar query (#226) * chore: convert native token to erc in axelar query * chore: deleting duplicate asset check * chore: move convertAssetDenom call out of try/catch block * 0.12.0-alpha.13 * chore: update alpha version Co-authored-by: npty <[email protected]> * chore(deps): bump json5 from 1.0.1 to 1.0.2 (#228) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Canh Trinh <[email protected]> * 0.12.0-alpha.15 * cleanup changelog * chore: update rpc/lcd configs * fix: osmosis chain id * 0.12.0 * chore: fix test * lint: fix * lint: fix Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: npty <[email protected]> Co-authored-by: Vladimir Agaev <[email protected]> Co-authored-by: npty <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #216
getGasReceiverContractAddressandgetDepositServiceContractAddressfunctions inAxelarAssetTransferand a duplicated function.getContractAddressFromConfigfunction inAxelarQueryAPIrefundAddresstodefault_refund_collector