chore: change executeData type from 0x${string} to string
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenFluin
approved these changes
Apr 5, 2024
npty
added a commit
that referenced
this pull request
Apr 18, 2024
* chore: fix gas limit function doc (#316) * chore: fix gas limit function doc * chore: remove mantle * chore: change executeData type from `0x${string}` to `string` (#317) * chore: change executeData type from `0x${string}` to `string` * chore: fix build error * chore: fix testnet rpc * Update issue templates * chore: bump axelar-cgp-solidity to 6.3.0 --------- Co-authored-by: Canh Trinh <[email protected]>
canhtrinh
added a commit
that referenced
this pull request
May 8, 2024
* chore: fix decimals issue with l2 dest chains (#315) * chore: fix decimals issue with l2 dest chains chore: delete unused test * 0.16.0-alpha.1 * chore: improve convertTokenAmount impl * chore: refactor bignumber amount conversion --------- Co-authored-by: npty <[email protected]> * chore: fix commandId generation (#321) * chore: fix gas limit function doc (#316) * chore: fix gas limit function doc * chore: remove mantle * chore: fix commandId generation * chore: update comment * chore: remove unused var * chore: update testnet rpc * chore: bump axelar-cgp-solidity to 6.3.0 (#324) * chore: fix gas limit function doc (#316) * chore: fix gas limit function doc * chore: remove mantle * chore: change executeData type from `0x${string}` to `string` (#317) * chore: change executeData type from `0x${string}` to `string` * chore: fix build error * chore: fix testnet rpc * Update issue templates * chore: bump axelar-cgp-solidity to 6.3.0 --------- Co-authored-by: Canh Trinh <[email protected]> * 0.16.0 * chore: update changelog for 0.16.0 * chore: remove unused import * chore: update changelog date --------- Co-authored-by: Canh Trinh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Current param types create compatibility conflicts with popular ecosystem libraries such as ethers.js. This can lead to type error issue.
Solution: Refactor param types to use string, aligning with standards used by most ecosystem libraries. This improves compatibility and avoids potential workarounds in the future.
AXE-3533