Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add estimateGasFeeGmp function #339

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add estimateGasFeeGmp function #339

wants to merge 4 commits into from

Conversation

npty
Copy link
Member

@npty npty commented Nov 28, 2024 •
edited
Loading

Closes https://axelarnetwork.atlassian.net/browse/AXE-5778

This PR adds estimateGMPFee function to make the usage a bit more clear and increase reusability of estimateMultihopFee

@npty npty requested a review from canhtrinh November 28, 2024 13:16
@npty npty self-assigned this Nov 28, 2024
@canhtrinh
Copy link
Collaborator

Thanks! This still needs estimateGasFeeTokenTransfer right?

@npty
Copy link
Member Author

npty commented Dec 18, 2024 •
edited
Loading

Thanks! This still needs estimateGasFeeTokenTransfer right?

could you please clarify the token transfer? Does the purpose of that function overlap with estimateMultihopFee?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canhtrinh canhtrinh Awaiting requested review from canhtrinh

At least 1 approving review is required to merge this pull request.

Assignees

@npty npty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npty @canhtrinh