Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evm package type issue #420

Closed
wants to merge 8 commits into from
Closed

fix: evm package type issue #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2919b2f
fix: evm package type issue
Aug 20, 2024
1fea14e
chore: update viem
Aug 20, 2024
47e850e
chore: change viem version
Aug 20, 2024
3d7c28a
chore: lockfile
Aug 20, 2024
de288c5
Merge branch 'main' into fix/versions
SGiaccobasso Aug 20, 2024
f0df7ba
chore: viem version
Aug 20, 2024
70c04cf
chore: viem version
Aug 20, 2024
5c31b1b
chore: add log to test
Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-ducks-march.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@axelarjs/evm": patch
---

fix type issue
2 changes: 2 additions & 0 deletions packages/deposit-address/src/get-deposit-address/isomorphic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ describe("requestConfigs", () => {
rpcUrl = axelarRpcUrl;
}

console.log("depositAddress", depositAddress);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't add console.log to production


expect(depositAddress).toBeTruthy();
expect(mod.getActiveChains).toHaveBeenCalledWith("testnet", {
axelarRpcUrl: rpcUrl,
Expand Down
2 changes: 1 addition & 1 deletion packages/evm/src/contracts/PublicContractClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class PublicContractClient<TAbi extends readonly unknown[]> {
address,
functionName,
abi: this.abi,
} as WriteContractParameters<TAbi, TFunctionName>;
} as unknown as WriteContractParameters<TAbi, TFunctionName>;
SGiaccobasso marked this conversation as resolved.
Show resolved Hide resolved

if (params?.args) {
contractParams["args"] = params.args;
Expand Down
49 changes: 36 additions & 13 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading