Skip to content

Commit

Permalink
addressed some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Foivos committed Nov 1, 2023
1 parent 3f6fa79 commit 854ce5d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions DESIGN.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ Most projects that look to go cross-chain nowadays have more complex needs that
- Mint/Burn: This `TokenManager` will burn/mint tokens from/to the user to initiate/fulfill cross-chain transfers. Tokens used with this kind of `TokenManager` need to be properly permissioned to allow for this behavior.
- Liquidity Pool: This `TokenManager` functions exactly like a Lock/Unlock one, except the balance is kept at a separate, pre-specified account. This allows for deployers to have more control over the bridged funds.

## Linker Router
## Interchain Address Tracker

We plan to finalize the design of the `InterchainTokenService` but we want to be able to support new chains as they get added to the Axelar Network. For this purpose, the service will ask a separate contract, the [`InterchainAddressTracker`](./contracts/interchainAddressTracker/InterchainAddressTracker.sol) to obtain the destination address for outgoing messages, and for validation of incoming messages. This contract might eventually stop being upgradable but it will probably be able to support new addresses for new chains indefinitely.
We plan to finalize the design of the `InterchainTokenService` but we want to be able to support new chains as they get added to the Axelar Network. For this purpose, the service will ask a separate contract, the [`InterchainAddressTracker`](https://github.com/axelarnetwork/axelar-gmp-sdk-solidity/blob/main/contracts/utils/InterchainAddressTracker.sol) to obtain the destination address for outgoing messages, and for validation of incoming messages. This contract might eventually stop being upgradable but it will probably be able to support new addresses for new chains indefinitely.

## Interchain Token

Expand Down
1 change: 1 addition & 0 deletions contracts/utils/Imports.sol → contracts/test/Imports.sol
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@

pragma solidity ^0.8.0;

// solhint-disable no-unused-import
import { InterchainAddressTracker } from '@axelar-network/axelar-gmp-sdk-solidity/contracts/utils/InterchainAddressTracker.sol';
import { InterchainAddressTrackerProxy } from '@axelar-network/axelar-gmp-sdk-solidity/contracts/utils/InterchainAddressTrackerProxy.sol';
2 changes: 1 addition & 1 deletion contracts/token-registrars/StandardizedTokenRegistrar.sol
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ contract StandardizedTokenRegistrar is IStandardizedTokenRegistrar, ITokenManage
tokenSymbol,
tokenDecimals,
distributor,
'',
distributor,
mintAmount,
operator,
destinationChain,
Expand Down

0 comments on commit 854ce5d

Please sign in to comment.