-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: inter-chain-token service events and errors [AXE-2064] #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with additional args for faster debugging
…ided in funciton args
Foivos
approved these changes
Oct 18, 2023
deanamiel
approved these changes
Oct 18, 2023
milapsheth
reviewed
Oct 18, 2023
# Conflicts: # test/TokenService.js
blockchainguyy
changed the title
refactor: inter-chain-token service events and errors
refactor: inter-chain-token service events and errors [AXE-2064]
Oct 19, 2023
Foivos
approved these changes
Oct 20, 2023
milapsheth
reviewed
Oct 26, 2023
deanamiel
approved these changes
Oct 31, 2023
milapsheth
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update errors and events as suggested here
Also fixed the tests due to these changes