Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build abi files into ts encoding files #140

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Conversation

canhtrinh
Copy link
Contributor

No description provided.

Copy link
Contributor

@alanrsoares alanrsoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 🇮🇹

@alanrsoares
Copy link
Contributor

alanrsoares commented Nov 3, 2023

you'll need to use interactive rebase to fix the conventional commit message check.
this commit hash da40b0b as the message exceeds the conventional commits length

@canhtrinh canhtrinh changed the title Feat/ts build feat: build abi files into ts encoding files Nov 3, 2023
scripts/codegen.ts Show resolved Hide resolved
re1ro
re1ro previously requested changes Nov 3, 2023
.github/workflows/publish-to-npm.yaml Outdated Show resolved Hide resolved
@alanrsoares alanrsoares dismissed re1ro’s stale review November 5, 2023 20:37

addressed the request by adding a rule for .yaml files to .prettierrc

@milapsheth milapsheth merged commit b84b30f into main Nov 6, 2023
4 checks passed
@milapsheth milapsheth deleted the feat/ts-build branch November 6, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants