-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added additional checks for call contract with token #249
feat: added additional checks for call contract with token #249
Conversation
…s-for-execute-with-token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only question was if we should put Express methods behind the access control modifier
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 98.70% 98.58% -0.12%
==========================================
Files 16 18 +2
Lines 541 567 +26
Branches 107 112 +5
==========================================
+ Hits 534 559 +25
Misses 2 2
- Partials 5 6 +1 ☔ View full report in Codecov by Sentry. |
Tests to hit:
for executeWithToken:
InvalidExpressMessageType(messageType)
on wrong message type.CallWithTokenMissmatch
on wrong amount OR token symbol.for expressExecuteWithToken:
CallWithTokenMissmatch
on wrong amount OR token symbol.InvalidExpressMessageType(messageType)
on wrong message type. Should be checked already but make sure.