New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed basestring NameError in Python3 #37

Closed

ulikoehler wants to merge 1 commit into axiak:master from ulikoehler:basestring

ulikoehler commented Dec 30, 2015

When installing pyre2 using pip3 and subsequently importing it, I get the following error message:

Traceback (most recent call last):
  File "./katc.py", line 3, in <module>
    from check import performRender
  File "/home/uli/dev/KATranslationCheck/check.py", line 28, in <module>
    from Rules import Severity, importRulesForLanguage
  File "/home/uli/dev/KATranslationCheck/Rules.py", line 4, in <module>
    import re2 as re
  File "re2.pyx", line 1, in init re2 (src/re2.cpp:13681)

This pull request fixes that by defining basestring globally in the pyx file if it is not defined (i.e. in python3)


          Fixed basestring NameError in Python3

404fb72

Author

ulikoehler commented Dec 30, 2015

Hm, I think #33 also fixes this, so I'll close my PR

ulikoehler closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet