Merge pull request #224 from axiomhq/expose-on-error-in-winston

feat(winston): expose onError method and pass it down to Axiom client

integration/src/winston.spec.ts

@@ -32,23 +32,27 @@ describe('WinstonTransport', () => {
     logger.log({
       level: 'info',
       message: 'Hello from winston',
+      callback: (err: Error) => {
+        console.error("winston failed to send logs", err)
+      }
     });
 
+    logger.end()
+
+    logger.on('finish', () => {
+      console.log('All logs have been sent');
+    })
+
     // Wait for the log to be sent
     await new Promise((resolve) => setTimeout(resolve, 1500));
 
     const startTime = new Date(new Date().getTime() - 1000 * 60 * 60 * 24).toISOString();
     const endTime = new Date(new Date().getTime() + 1000 * 60 * 60 * 24).toISOString();
 
-    // const res = await axiom.datasets.query(`['${datasetName}']`, {
-    //     startTime, endTime, streamingDuration: 'auto', noCache: false,
-    // });
-
-    const res = await axiom.queryLegacy(datasetName, {
-      resolution: 'auto',
-      startTime,
-      endTime,
+    const res = await axiom.query(`['${datasetName}']`, {
+      startTime, endTime, streamingDuration: 'auto', noCache: false,
     });
+
     expect(res.matches).toHaveLength(1);
   });
 });

packages/winston/src/index.ts

@@ -7,9 +7,9 @@ export interface WinstonOptions extends TransportStreamOptions {
   token: string;
   orgId?: string;
   url?: string;
+  onError?: (err: Error) => void;
 }
 
-// TODO: @arne get the error handling changes from axiom-node package
 export class WinstonTransport extends Transport {
   client: AxiomWithoutBatching;
   dataset: string;
@@ -23,6 +23,7 @@ export class WinstonTransport extends Transport {
       token: opts.token,
       orgId: opts.orgId,
       url: opts.url,
+      onError: opts.onError,
     });
     this.dataset = opts?.dataset || process.env.AXIOM_DATASET || '';
   }