Avoid "Comparison method violates its general contract!" exception

axkr · Sep 10, 2023 · b27a1a6 · b27a1a6
1 parent 79dcb7a
commit b27a1a6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/...y/matheclipse-core/src/main/java/org/matheclipse/core/expression/AbstractFractionSym.java b/...y/matheclipse-core/src/main/java/org/matheclipse/core/expression/AbstractFractionSym.java
@@ -435,7 +435,7 @@ public int compareTo(IExpr expr) {
         return c;
       }
       IExpr im = expr.im();
-      return !im.isPositive() ? 1 : -1;
+      return im.isPositive() ? -1 : im.isNegative() ? 1 : IExpr.compareHierarchy(this, expr);
     }
     return IExpr.compareHierarchy(this, expr);
   }

diff --git a/...ry/matheclipse-core/src/main/java/org/matheclipse/core/expression/AbstractIntegerSym.java b/...ry/matheclipse-core/src/main/java/org/matheclipse/core/expression/AbstractIntegerSym.java
@@ -380,7 +380,7 @@ public int compareTo(final IExpr expr) {
         return c;
       }
       IExpr im = expr.im();
-      return !im.isPositive() ? 1 : -1;
+      return im.isPositive() ? -1 : im.isNegative() ? 1 : IExpr.compareHierarchy(this, expr);
     }
     return IExpr.compareHierarchy(this, expr);
   }

diff --git a/...a_android_library/matheclipse-core/src/main/java/org/matheclipse/core/expression/Num.java b/...a_android_library/matheclipse-core/src/main/java/org/matheclipse/core/expression/Num.java
@@ -231,6 +231,8 @@ public int compareTo(final IExpr expr) {
       if (c != 0) {
         return c;
       }
+      IExpr im = expr.im();
+      return im.isPositive() ? -1 : im.isNegative() ? 1 : IExpr.compareHierarchy(this, expr);
     }
     return IExpr.compareHierarchy(this, expr);
   }