Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve android media player, also fix #2101 #2109

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Improve android media player, also fix #2101 #2109

merged 1 commit into from
Aug 28, 2024

Conversation

halx99
Copy link
Collaborator

@halx99 halx99 commented Aug 27, 2024

a. handle cbcr offset properly
b. handle output dim properly

Describe your changes

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 marked this pull request as ready for review August 27, 2024 17:28
@halx99 halx99 linked an issue Aug 27, 2024 that may be closed by this pull request
@halx99 halx99 added this to the 2.1.6 milestone Aug 27, 2024
@halx99 halx99 added the enhancement New feature or request label Aug 27, 2024
@halx99 halx99 force-pushed the fix-issue-2101 branch 4 times, most recently from 9f71def to 63f677c Compare August 28, 2024 16:37
a. handle cbcr offset properly
b. handle output dim properly
@halx99 halx99 merged commit 7025b1e into dev Aug 28, 2024
15 checks passed
@halx99 halx99 deleted the fix-issue-2101 branch August 28, 2024 17:40
xfbird pushed a commit to xfbird/axmol that referenced this pull request Sep 18, 2024
…2109)

a. handle cbcr offset properly
b. handle output dim properly
xfbird pushed a commit to xfbird/axmol that referenced this pull request Sep 18, 2024
…2109)

a. handle cbcr offset properly
b. handle output dim properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MediaPlayer Video not correctly rendered for Android (Galaxy S22 Ultra)
1 participant