-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(config-migration) Add the ability to determine and track the config version. #1699
Conversation
8ff45a1
to
08fc9e1
Compare
this looks like it has a failing test, not sure if you want to address that before i review or not |
I'll look into that first. I think it was a transient error from pnpm (ah, the joys of tests that require the network to function), but I'm re-running to verify that. |
08fc9e1
to
5965d0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general i think this is good, one thing to decide is the type of the version field (not sure i64 is the right call)
5965d0c
to
f577ede
Compare
f577ede
to
dd9692f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo small use statement nit
No description provided.