Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(config-migration) Add the ability to determine and track the config version. #1699

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

duckinator
Copy link
Contributor

No description provided.

@duckinator duckinator changed the title Add the ability to determine and track the config version. (config-migration) Add the ability to determine and track the config version. Jan 14, 2025
@ashleygwilliams
Copy link
Member

this looks like it has a failing test, not sure if you want to address that before i review or not

@duckinator
Copy link
Contributor Author

I'll look into that first. I think it was a transient error from pnpm (ah, the joys of tests that require the network to function), but I'm re-running to verify that.

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general i think this is good, one thing to decide is the type of the version field (not sure i64 is the right call)

cargo-dist/src/config/version.rs Show resolved Hide resolved
cargo-dist/src/config/version.rs Show resolved Hide resolved
cargo-dist/src/config/version.rs Outdated Show resolved Hide resolved
@duckinator duckinator marked this pull request as draft January 15, 2025 19:14
@duckinator duckinator marked this pull request as ready for review January 15, 2025 22:19
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo small use statement nit

@duckinator duckinator merged commit 214cd87 into main Jan 15, 2025
18 checks passed
@duckinator duckinator deleted the config-version branch January 15, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants