Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: rewrite relative links to additional pages #512

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Jul 3, 2023

this is currently hardcoded to SECURITY.md, and needs a more robust notion of relative links to pages we care about

(also this temporarily adjusts the repo to give a test case)

this is currently hardcoded to SECURITY.md, and needs a more robust notion of relative links to pages we care about
@ashleygwilliams
Copy link
Member

from @Gankra:

this PR needs much more work, but i think a lot of that work will happen while we work on monorepo (#493) stuff
the missing piece is a mapping from page ~names to page ~paths, so that the link rewriter knows what to rewrite.

that PR is basically providing the logic for editing the results of the markdown parser before rendering to html which I wanted to confirm was doable. ideally before we start rendering pages we have a listing of every page we will render so relative linking can work well (and maybe this also reduces the amount of need we have for path-prefix, if every page knows where exactly all other pages are in the hierarchy?)

@ashleygwilliams ashleygwilliams added this to the oranda-0.2.0 milestone Jul 14, 2023
@shadows-withal shadows-withal removed this from the oranda-0.2.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants