logproto: fixed state handling of the new internal handshake_in_progress flag #388
+39
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess flag There were multiple issues here - proto change did not force re-handshake if needed - initial state handling led to a drop of the first flush event both on client and server side that e.g. led to incorrect persist state processing at restart Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
fix-logproto-remove-handshake-in-progress
branch
from
f83b6b1
to
61b2abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple issues here
Signed-off-by: Hofi [email protected]