Add link on README to Docker Debugging #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Jan 12, 2024
Comment on lines
+135
to
+137
| >[!Tip] | ||
| > If you want to debug axolotl or prefer to use Docker as your development environment, see the [debugging guide's section on Docker](docs/debugging.md#debugging-with-docker). | ||
|
|
There was a problem hiding this comment.
Should this section be put under the "Contributing section"?
There was a problem hiding this comment.
I think lots of times people use docker to debug stuff and they may not think of contributing
At least all the questions I got were people wanting to debug but not necessarily contribute
We take for granted that people want to open PRs so I put this here to get people further into the funnel of debugging their issues
winglian
approved these changes
Jan 12, 2024
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* add docker debug * Update docs/debugging.md Co-authored-by: Wing Lian <[email protected]> * explain editable install * explain editable install * upload new video * add link to README * Update README.md * Update README.md * chore: lint * make sure to lint markdown too --------- Co-authored-by: Wing Lian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just merge if you approve LOL. Small change