-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config for optional parameters in a chat message #2260
Open
NJordan72
wants to merge
19
commits into
axolotl-ai-cloud:main
Choose a base branch
from
NJordan72:feat/optional-chat-template-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+892
−97
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d4ac2c8
feat: add config for optional parameters in a chat message
NJordan72 ab270e9
chore: cleanup
NJordan72 17a824a
chore: fix nits and add light docs
NJordan72 29d23f6
docs: update docs/dataset-formats/conversation.qmd
NJordan72 a36c4dc
Merge branch 'main' into feat/optional-chat-template-fields
NJordan72 c8ade2b
feat: configurable message mappings, jinja template analyzer
NJordan72 b1e8fab
chore: handle bradley terry
NJordan72 36aa1c0
docs: update docs
NJordan72 3f96f37
refactor: change order of mappings, improve message transform
NJordan72 8ea50e3
refactor: make chat awware of property mappings
NJordan72 0af59f7
chore: remove .python-version
NJordan72 2197c49
chore: revert change
NJordan72 1d0cba2
chore: add dataset validation to tests where appropriate
NJordan72 d0554d0
chore: add dataset validation to tests where appropriate
NJordan72 31b47e7
chore: clean up handling of ds_cfg
NJordan72 b2f93ea
chore: recursively serialize config
NJordan72 ff599a8
make sure to use the return value from validate_config
winglian 126b040
DefaultDict pickle/unpickle fix
winglian c265115
fix super call for override
winglian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly,
messages_array_name
refers to the key of theList[dict]
. Should we change the signature so thatfield_messages
is passed to the Prompter as well? To allow passingmessages_array_name=field_messages
?