TRL upgrade #2307
Open
TRL upgrade #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from pydantic import BaseModel, Field | ||
|
|
||
|
|
||
| class TrlConfig(BaseModel): |
There was a problem hiding this comment.
This looks great : )
clean path and add mounts handle mounting
abodacs
reviewed
Feb 10, 2025
| texts, | ||
| return_tensors="pt", | ||
| padding=True, | ||
| padding_side="right", |
There was a problem hiding this comment.
why there padding_side mismatched between reward_inputs and prompt_inputs?
There was a problem hiding this comment.
this was a copy/paste from upstream trl trainer as I needed this PR to land to simplify our end. https://github.com/huggingface/trl/pull/2817/files I've removed this method from this class now that the referenced PR is merged.
| @@ -576,7 +576,7 @@ def prepare_opinionated_env(cfg): | |||
| def setup_trainer( | |||
| cfg, train_dataset, eval_dataset, model, tokenizer, processor, total_num_steps | |||
| ): | |||
| if cfg.rl in ("dpo", "ipo", "orpo", "kto", "simpo"): | |||
| if cfg.rl in ("dpo", "grpo", "ipo", "orpo", "kto", "simpo"): | |||
There was a problem hiding this comment.
I think we can just check for if cfg.rl here right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip towards adding support for GRPO