Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add tensorboard support #768

Closed

Conversation

NanoCode012
Copy link
Collaborator

Should close #763

Untested, but should work.

@NanoCode012 NanoCode012 mentioned this pull request Oct 22, 2023
5 tasks
@winglian
Copy link
Collaborator

winglian commented Oct 23, 2023

based on the docs, perhaps we should convert this to None if it's empty? that way it should default back to the all case if not setup

report_to (str or List[str], optional, defaults to "all") — The list of integrations to report the 
results and logs to. Supported platforms are "azure_ml", "clearml", "codecarbon", 
"comet_ml", "dagshub", "flyte", "mlflow", "neptune", "tensorboard", and "wandb". Use 
"all" to report to all integrations installed, "none" for no integrations.

@ein-ich
Copy link
Contributor

ein-ich commented Oct 23, 2023

Ok I tested it and it works; but I realized it even works on main and without tensorboard: true. It seems it always created a tensorboard runs logdir in output_dir, and I just never noticed?

@winglian
Copy link
Collaborator

Ok I tested it and it works; but I realized it even works on main and without tensorboard: true. It seems it always created a tensorboard runs logdir in output_dir, and I just never noticed?

Maybe it never did that until you installed the tensorboard package?

@ein-ich
Copy link
Contributor

ein-ich commented Oct 23, 2023

Yes you're right, it only creates the logs when tensorboard is installed.

@NanoCode012
Copy link
Collaborator Author

Ok I tested it and it works; but I realized it even works on main and without tensorboard: true. It seems it always created a tensorboard runs logdir in output_dir, and I just never noticed?

Hmm, that's weird. It should've been report_to=None if not using wandb, which according to the docs would not have any integration. Maybe tensor board logs are just defaulted? In such a case, is this PR needed?

@ein-ich
Copy link
Contributor

ein-ich commented Oct 24, 2023

@winglian
Copy link
Collaborator

Yeah, I think the only thing we need is to add tensorboard to the requirements.txt or to document that people should install it if wanted. I'm leaning towards just installing it with requirements or maybe with an extras like pip install -e .[tensorboard]

@NanoCode012 NanoCode012 marked this pull request as draft October 26, 2023 10:02
@NanoCode012
Copy link
Collaborator Author

Closed in favor of adding tensorboard to requirements

@fakerybakery
Copy link

Hi, sorry I'm a bit confused, how do I use Tensorboard in Axolotl then?

@NanoCode012
Copy link
Collaborator Author

@fakerybakery , you can just train normally without setting wandb configs or setting it to disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tensorboard
4 participants