feat: add dentrite testnet #762
Conversation
WalkthroughThe changes involve updates to various configuration files and documentation within the Axone blockchain project. Key modifications include the replacement of a network option from "drunemeton-1" to "dentrite-1" in the issue template, updates to Docker image references in workflow files, the addition of new documentation for the "dentrite-1" network, and the introduction of a new version number in the version file. These changes collectively reflect updates in network options and documentation for validator registration. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
chains/dentrite-1/genesis.jsonis excluded by!**/*.jsonchains/dentrite-1/register-config.jsonis excluded by!**/*.json
Files selected for processing (7)
- .github/ISSUE_TEMPLATE/register-validator.yml (1 hunks)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/test.yml (2 hunks)
- README.md (1 hunks)
- chains/dentrite-1/README.md (1 hunks)
- chains/dentrite-1/README.md.gtpl (1 hunks)
- chains/dentrite-1/version.txt (1 hunks)
Files skipped from review due to trivial changes (3)
- .github/ISSUE_TEMPLATE/register-validator.yml
- README.md
- chains/dentrite-1/version.txt
Additional context used
LanguageTool
chains/dentrite-1/README.md
[style] ~4-~4: Using many exclamation marks might seem excessive (in this case: 3 exclamation marks for a text that’s 1312 characters long)
Context: ...--dentrite--1-blue?style=for-the-badge)
actionlint
.github/workflows/test.yml
95-95: shellcheck reported issue in this script: SC2086:info:1:53: Double quote to prevent globbing and word splitting
(shellcheck)
95-95: shellcheck reported issue in this script: SC2046:warning:1:130: Quote this to prevent word splitting
(shellcheck)
95-95: shellcheck reported issue in this script: SC2006:style:1:130: Use $(...) notation instead of legacy backticks
...(shellcheck)
Additional comments not posted (13)
chains/dentrite-1/README.md (4)
1-8: LGTM!The header and badges section is informative and well-structured.
Tools
LanguageTool
[style] ~4-~4: Using many exclamation marks might seem excessive (in this case: 3 exclamation marks for a text that’s 1312 characters long)
Context: ...--dentrite--1-blue?style=for-the-badge)(EN_EXCESSIVE_EXCLAMATION)
10-25: LGTM!The "Register in the Genesis" section provides clear and comprehensive instructions for registering a validator node.
27-42: LGTM!The "Create the gentx" section provides a well-documented script with all necessary parameters for creating a gentx.
Line range hint
44-71: LGTM!The "Genesis validators" section provides a well-structured table with comprehensive information about the genesis validators.
Tools
LanguageTool
[style] ~4-~4: Using many exclamation marks might seem excessive (in this case: 3 exclamation marks for a text that’s 1312 characters long)
Context: ...--dentrite--1-blue?style=for-the-badge)(EN_EXCESSIVE_EXCLAMATION)
.github/workflows/lint.yml (1)
119-119: LGTM! But verify the new Docker image reference.The change in the Docker image reference might reflect a rebranding or restructuring of the Docker image repository. Ensure that the new Docker image reference is correct and accessible.
Run the following script to verify the new Docker image reference:
chains/dentrite-1/README.md.gtpl (4)
1-8: LGTM!The header and badges section is informative and well-structured.
10-25: LGTM!The "Register in the Genesis" section provides clear and comprehensive instructions for registering a validator node.
27-42: LGTM!The "Create the gentx" section provides a well-documented script with all necessary parameters for creating a gentx.
44-71: LGTM!The "Genesis validators" section provides a well-structured table with comprehensive information about the genesis validators.
.github/workflows/test.yml (4)
69-69: LGTM!The Docker image name update is correct and ensures the correct Docker image is used.
79-79: LGTM!The Docker image name update is correct and ensures the correct Docker image is used.
84-84: LGTM!The Docker image name update is correct and ensures the correct Docker image is used.
90-90: LGTM!The Docker image name update is correct and ensures the correct Docker image is used.
| genesis collect-gentxs \ | ||
| --home /.axoned | ||
|
|
||
| - name: Start the blockchain | ||
| run: | | ||
| docker run --network host --rm --name axone-node -v ${GITHUB_WORKSPACE}/${{ matrix.context.path }}:/.axoned axone-protocol/axoned:`cat ./chains/${{ matrix.context.network }}/version.txt` \ | ||
| docker run --network host --rm --name axone-node -v ${GITHUB_WORKSPACE}/${{ matrix.context.path }}:/.axoned axoneprotocol/axoned:`cat ./chains/${{ matrix.context.network }}/version.txt` \ |
There was a problem hiding this comment.
LGTM! But fix the flagged issues.
The Docker image name update is correct and ensures the correct Docker image is used. However, the static analysis tools have flagged issues related to quoting and use of backticks.
Apply this diff to fix the flagged issues:
- docker run --network host --rm --name axone-node -v ${GITHUB_WORKSPACE}/${{ matrix.context.path }}:/.axoned axoneprotocol/axoned:`cat ./chains/${{ matrix.context.network }}/version.txt` \
+ docker run --network host --rm --name axone-node -v "${GITHUB_WORKSPACE}/${{ matrix.context.path }}":/.axoned axoneprotocol/axoned:$(cat ./chains/${{ matrix.context.network }}/version.txt) \
start \
--home /.axoned \
--moniker axone-node &Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| docker run --network host --rm --name axone-node -v ${GITHUB_WORKSPACE}/${{ matrix.context.path }}:/.axoned axoneprotocol/axoned:`cat ./chains/${{ matrix.context.network }}/version.txt` \ | |
| docker run --network host --rm --name axone-node -v "${GITHUB_WORKSPACE}/${{ matrix.context.path }}":/.axoned axoneprotocol/axoned:$(cat ./chains/${{ matrix.context.network }}/version.txt) \ | |
| start \ | |
| --home /.axoned \ | |
| --moniker axone-node & |
Add the
axone-dentrite-1testnetDetails
Genesis start time:
2024-09-10T12:00:00ZRegister before:
2024-09-07T00:00:00ZAxoned version:
v10.0.0