XIVY-15609 Improve path encoding for signing request #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using UrlEncoder which is not especially designed for this. It's hard to find out, how the calling end url is, because this relies on the underlying technology jersey -> connectory -> apache http connector. Tried a lot of stuff and this implementation was the best. It specially handles the characters which are also specially handled in UrlEncoder. The main problem is that we should not allow to create such documents. We should difference between a display name and a technical file name.
alexsuter
force-pushed
the
fix-path-enconding
branch
from
2f5e1f8 to
51c867c
Compare
weissreto
reviewed
Dec 9, 2024
It does not escape whitespaces and other chars. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using UrlEncoder which is not especially designed for this.
It's hard to find out, how the calling end url is, because
this relies on the underlying technology jersey -> connectory
-> apache http connector. Tried a lot of stuff and this implementation
was the best. It specially handles the characters which are also
specially handled in UrlEncoder.
The main problem is that we should not allow to create such documents.
We should difference between a display name and a technical file name.
@weissreto I'm not happy with the solution, but invested already multiple hours. This solution is at least working for a lot of special characters.