Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to 12.0 🐫 #29

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Migrate to 12.0 🐫 #29

merged 8 commits into from
Dec 13, 2024

Conversation

ivy-rew
Copy link
Member

@ivy-rew ivy-rew commented Nov 29, 2024

A friendly conversion provided by market-up2date-keeper 🤖 🤝

Copy link
Contributor

github-actions bot commented Nov 29, 2024

Test Results

1 tests  ±0   1 ✅ ±0   9s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5b65d53. ± Comparison against base commit 0195805.

♻️ This comment has been updated with latest results.

@ivy-lli
Copy link
Member

ivy-lli commented Dec 12, 2024

The ecoding shouldn't fixed like this: https://github.com/axonivy-market/currency-converter-connector/pull/29/files/3459e5c0fa2996f4d2289b16784c2c1d9a86bcb8..eff589b6d1ab7bd6279e50939f4b2c4d0e3560fa
But like that: https://github.com/axonivy-market/demo-projects/pull/629/files

Otherwise you will face import errors via market that the org.eclipse.core.resources.prefs file is readonly.

@ndkhanh-axonivy
Copy link
Contributor

Thank you @ivy-lli , I'm fixing it now!

Copy link
Contributor

@quanpham-axonivy quanpham-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndkhanh-axonivy ndkhanh-axonivy merged commit f62ff4f into master Dec 13, 2024
6 checks passed
@ndkhanh-axonivy ndkhanh-axonivy deleted the raise-to-12.0.0-SNAPSHOT branch December 13, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants