MARP-59 migrate the marketplace from ivyteam jenkins to GitHub #30
Conversation
Test Results107 tests 107 ✅ 38s ⏱️ Results for commit f884194. ♻️ This comment has been updated with latest results. |
src/app/domain/market/Product.php
Outdated
| @@ -339,6 +339,7 @@ private function assetBaseUrl_versionized(string $version): string | |||
| { | |||
| $key = $this->product->getKey(); | |||
| $artifactId = $this->product->getProductArtifactId(); | |||
| echo "/market-cache/$key/$artifactId/$version"; | |||
tutn-axonivy
deleted the
MARP-59-Migrate-the-Marketplace-from-Ivyteam-Jenkins-to-Github
branch
|
Hi @tutn-axonivy |
|
As you are doing first steps in this repo I think you should let the work review by the initial contributors. Especially @alexsuter in this repo. |
|
I like that you have formatted the code with .editorconfig. But please if you make such reformattings then do this in an own PR. So that we see that this PR is only a formatting PR and should not change the behavior. Do we have any behavior changes in this PR? |
|
You changed the Dockerfile which is currently in charge. |
|
I did some tricks to make it run in my local. I'm so sorry for not discarding it when committing the code. |
No problem; we're glad you're contributing after all. 🤝 |
No description provided.