Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubar placement in WP #20

Closed
colemanw opened this issue Nov 20, 2018 · 7 comments
Closed

Menubar placement in WP #20

colemanw opened this issue Nov 20, 2018 · 7 comments

Comments

@colemanw
Copy link
Collaborator

Currently the CiviCRM menu covers up the WP top navigation menu. This may not be necessary or desirable. Discuss...

@aydun
Copy link
Owner

aydun commented Nov 21, 2018

One consideration for the placement of menus is the impact on accessibility and use with screen readers. I think hiding other menus and just displaying the Civi one along with an option to toggle back to the CRM menus may be better as it reduces the clutter - but I'm no expert. I'll flag this in the ~accessibility channel.

@JoeMurray
Copy link

tl;dr toggling between cms and civi menus is good enough imho

In Drupal default install, the first menu dropdown for the CiviCRM menu has an option to 'Hide' the CiviCRM menu which in a standard Drupal install will reveal a Drupal menu that had been hidden. It also creates popup to restore the CiviCRM menu. The popup does not last if one navigates away from the page.

WCAG is concerned with perceivability of functionality. However, so long as our menu allows user to get back to main (CMS) menu, and the main (CMS) menu allows user to get to CiviCRM then I think we're okay from an accessibility compliance perspective.

Whether hiding the main menu is a good usability practice including from the perspective of accessibility is a good question. I think it is a reasonable choice as the tendency is to have long sessions of work within CiviCRM's backend context, not regular back and forth between CiviCRM and the CMS. There is an exception in WordPress, where after creating CiviCRM content for public exposure it is necessary to go over to WP to create / update content to include a shortcode to expose CiviCRM content to the public.

@colemanw
Copy link
Collaborator Author

colemanw commented Nov 21, 2018

I do think that for the sake of accessibility hiding the CMS menu with display: none is better than just covering it up with an aggressive z-index, as the former will help screen readers and keyboard navigation to know the hidden menu isn't supposed to be interacted with.

I think for both of these problems (placement in WP & Joomla, hiding the menu in Drupal) it's ok to add some cms-specific css & js files. We can try to make this menu code as generic as possible but a few tweaks for each cms are acceptable & beneficial. I'll roll up a PR for that.

@colemanw
Copy link
Collaborator Author

Well it's not too hard to achieve what @christianwach suggested... here it is.
What I'm not sure of is whether or not this is an actual improvement. 2 menubars takes up more screen space, the top WP bar isn't really doing much, and there is the "hide menu" option on the CiviCRM nav bar already.

screenshot from 2018-11-22 08-39-48

@christianwach
Copy link

I'm not a fan of obscuring the native WordPress menu, but the alternatives seem worse. There was discussion on a CAU issue a few years ago - no conclusion reached however. I'd vote for keeping as is for the moment.

@colemanw
Copy link
Collaborator Author

Yes that's what I've concluded as well.

@colemanw
Copy link
Collaborator Author

colemanw commented Nov 26, 2018

@aydun @christianwach @JoeMurray I've decided to let the user choose instead of us choosing for them:
#21
Please test this out on your favorite CMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants