Improve markup and css for WP

[colemanw]

Overview

Improves the menu styling across CMSs, but especially for WP.

Before

Menu doesn't even appear in WP.

After

Menu appears, and looks nice :)

[colemanw]

@christianwach I think you'll find this makes the menubar work well in WP without the admin tools plugin. Additional css tweaks you think are important would be welcome.

[christianwach]

Menu appears, and looks nice

I can confirm that the menu does now appear on desktop-sized viewports. However, it is still not visible on viewports below 768px wide.

I think you'll find this makes the menubar work well in WP without the admin tools

Being the style pedant that I am, I still see a lot of enhancements in CAU's overrides, for example:

• support for WordPress admin colour schemes
• match menu height to WordPress admin bar
• match positional behaviour of menu with WordPress admin bar
• match shadows on sub-menu dropdowns
• no overlap of WordPress menu hamburger below 768px

Will this extension become part of the core repo or will it be included via the build script? It'd be useful to know before tackling any of this outside of my CAU comfort zone.

[colemanw]

@christianwach thanks for the feedback. The plan is indeed to move the code from this extension into core and remove the existing menubar plugin from core (which as you've noted is abysmal).

So I'd like to get on the same page with you about necessary vs pedantic styles. I think it's fine to keep things like color-scheme tweaks in your CAU plugin, but IMO since the code in this extension is soon to be core code, we need to ensure all the functional css is working - the menu has the correct height and the hamburger menu functions correctly are in the must-haves I believe, and I'd really welcome a PR from you if you've developed any code for those things.

[christianwach]

I'd really welcome a PR from you if you've developed any code for those things.

Happy to help. Do you mean a PR on this repo?

[aydun]

Ok, I'll merge this as is since making the menu appear on WP is a good thing - and look forward to another PR from @christianwach for further improvements.

[colemanw]

Happy to help. Do you mean a PR on this repo?

Yes, and thanks for all your excellent work on CAU so far. I'm hoping that by the time we move this extension into core we'll have a well-functioning menu that plays nice with every CMS (and to that end, let's open another issue about menubar placement in WP)

[colemanw]

@christianwach see #20