Fix warnings and other little things #81
Closed
+66
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieucarbou
force-pushed
the
warnings
branch
2 times, most recently
from
efc1425 to
6c66901
Compare
On Arduino 3, type definition has changed. It is recommended to use PRIu32 / PRId32 / PRIu16 / PRI16 / etc for printf formats
|
@ayushsharma82 : this PR is ready |
|
Needs conflicts to be resolved. |
This PR was containing all the improvement to the existing code, without the WSL_HIGH_PERF version. Since you've merged the WSL_HIGH_PERF version into dev, this PR is not needed for dev since the WSL_HIGH_PERF version also included all the little improvements to the existing code. I've changed the base to master: depending on your release plan and process, it can either be merged to master or be closed if dev will be merged to master ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Arduino 3, type definition has changed. It is recommended to use PRIu32 / PRId32 / PRIu16 / PRId16 / etc for printf formats