Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with numpy>=2 #2282

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Make compatible with numpy>=2 #2282

merged 1 commit into from
Nov 27, 2024

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Nov 26, 2024

Overview

This PR makes a couple of small fixes to make the codebase compatible with numpy>=2. However, it does not update the required numpy version because of #2283. This means that docker images will still be built with numpy 1 for now, but users installing via pip will be able to install it alongside numpy>=2.

Testing Instructions

This was tested by updating to numpy==2.1.3 inside the docker container and then checking that unit and integration tests succeed.

@AdeelH AdeelH marked this pull request as ready for review November 27, 2024 00:47
@AdeelH AdeelH merged commit e777796 into azavea:master Nov 27, 2024
2 checks passed
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (fb3b199) to head (1b8c4a6).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
- Coverage   90.31%   90.25%   -0.07%     
==========================================
  Files         199      199              
  Lines        9925     9925              
==========================================
- Hits         8964     8958       -6     
- Misses        961      967       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdeelH AdeelH deleted the numpy2 branch November 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant