Add audacious to SUPPORTED_PLAYERS. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the patch. Can you confirm that you tested the extensions with audacious and it worked fine? |
Philantrop
pushed a commit
to Exherbo/media-unofficial
that referenced
this pull request
Nov 27, 2013
1) There is no much gain in it. It might only be interesting to those who want to use things like http://www.emacswiki.org/emacs/MPRIS or https://extensions.gnome.org/extension/54/mpris-player-control/ (note azdyb/gnome-shell-extension-mpriscontrol#3) 2) In the present state to make sense it must be DEFAULT_ENABLEd for audacious-plugins as well because the mpris functionality is split in 2 parts: one part is in audacious core doing bindings to controls and the other part is in plugin that registers the interface in dbus and listens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Audacious is a good gtk+-3 audio player http://audacious-media-player.org/ that supports mpris. mpriscontrol works fine with it. Just added to list. :)
Had a thought that maybe I should rebase the commit to master.