Trial of the crusader: faction champions' stats are not scaled down

[WangDianhui]

Describe your feature request or suggestion in detail

If there are characters whose reputation with Argent Crusade is friendly or more in the instance, the faction champions' stats would not be scaled.

[pangolp]

How strange that he does not climb with the champions ...
I haven't really used this module, it has many configurations...
I'll have to try it.

[cdenq]

Is your party cross-faction by any change? Scaling will apply properly if everyone is the same faction.

[kjack9]

I want to wait until #155 is merged and then troubleshoot this if its still happening - that will give us some more detail via the .ab mapstat and .ab creaturestat commands.

[WangDianhui]

This problem still exists. I have already pulled the latest commit for both server and mod.



The champions' HP does not change as the num of players changes.

[WangDianhui]

I think I've found the problem...

If the party leader's name contains chinese characters, the champions' stats would not be changed. But for English names, the mod works properly.

[kjack9]

Wow, I have no idea what could possibly be causing that. The mod doesn't care about character names for making decisions. It DOES have character names in some of the announcements, but I can't think of why that would matter.
I don't even know where to begin on troubleshooting this.

Marking "Help Wanted" for now.

[WangDianhui]

I've confirmed that the problem is independence with the name. But it just occurred when there are some SPECIFIC characters in the instance, no matter who the party leader is.

I'm still looking for the trigger condition.

[WangDianhui]

Confirmed. If there are characters whose reputation with Argent Crusade is friendly or more in the instance, the faction champions' stats would not be scaled.

[kjack9]

I've added this to my personal backlog.

[kjack9]

@WangDianhui can you please test with the latest version of AC and AutoBalance and let me know if the issue is still happening?

[WangDianhui]

@WangDianhui can you please test with the latest version of AC and AutoBalance and let me know if the issue is still happening?

Tested, the problem has gone. Champions' scaling are now irrelevant with reputation.

[kjack9]

@WangDianhui can you please test with the latest version of AC and AutoBalance and let me know if the issue is still happening?

Tested, the problem has gone. Champions' scaling are now irrelevant with reputation.

Great! Closing as confirmed fixed by #157