World damage/healing, destructible buildings, multiplier rewrite, logging improvements #157

kjack9 · 2023-10-12T00:38:19Z

Changes Proposed:

This is a fairly major rewrite of large parts of AutoBalance. While the user-facing side of things (the .conf file) is hardly changed at all, the internals behind it are quite different.

Observable changes

Handle damage and healing that doesn't come from a creature (world damage, self-damage, NPC healing, etc)
Destructible buildings have the damage done to them scaled appropriately based on the scaling settings
More reliable boss and boss summon detection - both get treated as bosses for multipliers
Rewrite of in-combat locking for players leaving the instance during combat - if any player in the instance is in combat, the difficulty only goes UP until combat ends
Reduce "level up animation" events on creatures by setting their level before they're spawned into the world
Improved player notifications when entering/exiting dungeons
Add commands and logger info to README.md, update the GitHub bug template

Less-obvious changes

Complete rewrite of the level/player scaling process, separating many pieces of repeated code into functions
Improved handling of GMs entering/exiting the instance
Handle debuffs that do "X% of player health" damage correctly - do not level scale
Performance improvements, with fewer unneeded checks being performed
Fewer incorrectly-scaled creatures (flavor critters, player summons, friendly NPCs, other irrelevant creatures)
Improved .ab mapstat and .ab creaturestat output
Many many many many debug logs added or changed, including the start of splitting the logs into different logging sinks. Detailed multiplier calculation logs, damage adjustment logs, combat locking logs.
Many settings are now stored in the map data itself, paving the way for map-specific settings in the future

Issues Addressed:

SOURCE:

N/A

Tests Performed:

tested on latest AC with four people doing multiple dungeons and raids

Known Issues and TODO List

disabled for Battlegrounds entirely. It already wasn't working correctly and was causing crashes in some cases (Bug: AutoBalance + NPCBots: Bots joining BG cause segmentation fault #148). I have it in my backlog to try to re-add it eventually.
disabled LevelScaling.EndGameBoost which is currently WAAAAY overtuned (Bug: AutoBalance.LevelScaling.EndGameBoost is overtuned #156). I need to figure out how the original developers of the module came up with the multipliers they did, and if they are still needed given how I'm generating multipliers now.
Bug: Vehicle-based Combat is inconsistent #158

I'm tempted to work on these before submitting this PR but... do you really want this to be any larger?

How to Test the Changes:

Use AutoBalance as normal. The user-facing changes should be minimal. However, there will likely be encounters that were previously scaled incorrectly and may now be possible.

- Add worldHealthMultiplier, intended to be used to scale the health of attackable game objects in the instance

- tear out and re-implement all the damage handling to ensure more cases are handled - use the map's damage modifier when damage happens where the source isn't a creature - better handle when the source of damage no longer exists (logged out or despawned) - extensive (optional) logging under the `module.AutoBalance.Damage` logging prefix - WIP implementattion of game object damage handling (destructible buildings) - fix a long-standing error in the class name for some logging

- need to apply statmodifiers still - improved logging

- fix a bug with the enable check case statements (stupid case breaks) - remove antiquated battleground checks - should never scale in battlegrounds - better handle "special" creatures (totems, triggers, critters) - allow combat critters to scale correctly - allow intentionally-low-level triggers and critters to remain low level - workaround an issue with summons showing the wrong level client-side (level change ramp up) - further improve GM and user commands - erase map AB info from maps when they are created, preventing issues with instance ID re-use - better handle instances with no non-GM characters (disable scaling temporarily)

- removed unnecessary `std::string`s

- majory re-wrote the multiplicer calculations to increase accuracy and clarity - take advantage of new `OnBeforeCreatureSelectLevel` hook to set the initial level of creatures before they are added to the world - separated level-scaled and non-level-scaled multipliers for tracking and display - move creature relevancy check to new function `isCreatureRelevant` - rename many variables to standardize and clarify - add option to force a map stats update, to be used when a player enters the map - players leaving the map are no longer included in the map's stats - sweeping improvements in logging of the multiplier calculation process (`AutoBalance.StatGeneration`) - update `.ab creaturestat` to show new scaled modifiers in an understandable way

- replace kludgy player count detection with an internal player list (more features coming Soon) - skip scaling on player-owned summons, totems, etc - skip scaling on flavor critters but not on combat critters - separate map and global config times, reducing the work to refresh if only a map config changes - centralize detection of "non-relevant" creatures, use a `skipMe` tag to speed up processing - correctly handle a GM leaving the instance who was previously a non-GM when they entered - temporarily disable in-combat checking - improve logging format to produce the ID needed for `.go creature <UUID>` - standardize logging format

- moved enums to top the file, added `Relevance` enum - improve performance of `isCreatureRelevant` but saving the decision from previous runs - fix issues with summon detection to (hopefully) cover all edge cases - consolidate and fix StatModifier case selection, add debugs - more logging improvements all around

…, improve `.ab mapstat`

- boss summons now also count as a "boss"

…Runes, etc - logging improvements

- percent-based damage auras will now ignore level scaling (per-player scaling only) - map multipliers (damage/healing and health) will now honor the level scaling setting - use a custom struct to store and move around world multipliers - properly remove LevelScalingEndGameBoost until it can be fixed (azerothcore#156) - creatures summoned by a boss will now be scaled like bosses - further refinement of trigger handling logic - fix active creature not being decremented on creature removal - fix incorrect announcing of GMs entering/exiting the instance - improvements for in-game commands - continued log improvements

- logging improvements

kjack9 · 2023-10-13T19:24:59Z

~~I found a small regression - totems for enemies are not being level scaled currently. I will work on a fix.~~

pangolp · 2023-10-13T21:14:42Z

Particularly, I prefer to work on smaller pull requests, because if you had to revert any of these changes, you would practically have to revert everything. However, it seems like it's a pretty big deal, so if you guys think it's okay, that's fine by me. I would leave it here, and not add anything else, and at most, once the merger is done, in any case, I would correct any possible errors, or add new improvements in other pull requests. I wouldn't modify this anymore.

kjack9 · 2023-10-14T05:58:20Z

~~I found a small regression - totems for enemies are not being level scaled currently. I will work on a fix.~~

Fixed in that last commit.

kjack9 · 2023-10-14T06:02:57Z

Particularly, I prefer to work on smaller pull requests, because if you had to revert any of these changes, you would practically have to revert everything. However, it seems like it's a pretty big deal, so if you guys think it's okay, that's fine by me. I would leave it here, and not add anything else, and at most, once the merger is done, in any case, I would correct any possible errors, or add new improvements in other pull requests. I wouldn't modify this anymore.

I totally hear you and agree in principal. So far I've been pretty bad at doing small PRs.

In my defense this time, very little is changing from the user's perspective. Some stuff that didn't work will work now, but the operation of the module will largely remain the same.

A ton of the behind-the-scenes work I'm doing is on edge cases, code organization, and fully commenting/debug logging the entire module. When I started there was some pretty cryptic stuff happening in the code that I've done my best to un-cryptify (definitely a word, don't look it up). There was also very little to no logging, which made troubleshooting issues a bear.

So while yeah, this PR is quite large, the mod is doing pretty close to the same things it was doing before, but hopefully more consistently and with code that is easier for someone else to decipher and troubleshoot. If it helps, I have a whole list of new features I'd love to implement that I've held off on until we get this one merged in.

I also struggle with how to maintain momentum working on this thing (I'm hot/cold when it comes to motivation to work on stuff) if I submit small PRs and they take a week each to get approved. There's no way the work I did here would have happened if I'd submitted a PR after the first couple of commits.

So again, sorry - I know it's not ideal. Hopefully the gains are worth the headache, and that you and the module users can see the difference in the results they're getting.

Thank you for attending my TED talk.

WangDianhui · 2023-10-14T17:53:24Z

Not working on heroic ICC and Ruby sanctum. The map level is zero.

But working on all normal raids and heroic TOC.

kjack9 · 2023-10-14T18:09:23Z

Not working on heroic ICC and Ruby sanctum. The map level is zero.
But working on all normal raids and heroic TOC.

I will check it out, thank you! I wonder why your LFG doesn't have levels for those? I may need to stop relying on that for level information...

EDIT: Confirmed, heroic ICC doesn't have LFG information. Hrm, I will have to think about how to handle that. I'm using that info for some decision making...

EDIT2: I think I'm going to just pull the info from the normal version. For my purposes, that will be okay for checking creature levels and the like.

kjack9 · 2023-10-14T23:37:47Z

Not working on heroic ICC and Ruby sanctum. The map level is zero.
But working on all normal raids and heroic TOC.

This is fixed now, can you please test with the latest commit?

If a particular heroic dungeon has no entry in the LFG system, the non-heroic version will be used to get level data.

- fix display issue with active creatures

- that'll teach me to commit before I build

WangDianhui · 2023-10-15T07:56:47Z

Not working on heroic ICC and Ruby sanctum. The map level is zero. But working on all normal raids and heroic TOC.

This is fixed now, can you please test with the latest commit?

If a particular heroic dungeon has no entry in the LFG system, the non-heroic version will be used to get level data.

Tested, Heroic ICC looks good now, thanks for the effort!

But there brings a new problem to Halion

Normal procedure:

Damage white Halion to 75% HP
White Halion disappear, black Halion shows up in twilight realm with 75% HP
Smash black Halion to 50% HP
White Halion shows up again with 50% HP
Beat Halion in both realm to death. The HP of white and black Halion is linked.

After the update of the mod, black Halion shows up with only 12% of HP in step2. So step3 is skipped, and in step4, white Halion show up with 75% of HP.

I think the problem is that when black Halion spawn in twilight realm, an extra modifier is applied to it. 0.15 in this case.

kjack9 · 2023-10-15T18:03:07Z

Tested, Heroic ICC looks good now, thanks for the effort!

But there brings a new problem to Halion

Normal procedure:
1. Damage white Halion to 75% HP

2. White Halion disappear, black Halion shows up in twilight realm with 75% HP

3. Smash black Halion to 50% HP

4. White Halion shows up again with 50% HP

5. Beat Halion in both realm to death. The HP of white and black Halion is linked.
After the update of the mod, black Halion shows up with only 12% of HP in step2. So step3 is skipped, and in step4, white Halion show up with 75% of HP.

I think the problem is that when black Halion spawn in twilight realm, an extra modifier is applied to it. 0.15 in this case.

Got it, will see what I can do.

- track summoner as a part of AutoBalanceCreatureInfo - detect when a summon is a clone and use the correct current health instead of scaling again - add summon information to `.ab creaturestat` - as always, logging improvements

kjack9 · 2023-10-16T09:30:18Z

But there brings a new problem to Halion

Well, this was trickier to fix than I expected.

The problem is that when a clone is made, the max health gets reset to the original max health for the new clone. However, the current health value (whatever the creature's actual health value is) is COPIED onto the new clone. That means that the max health was getting (correctly) scaled down but the current health was ALSO getting (incorrectly) scaled down.

Funny enough, it's really hard to tell when this cloning process has happened. To handle it, I created a simple scoring system that checks several properties of the summon and its summoner to determine if it is a clone. If it is, the max health is still scaled but the current health is left unchanged.

I tested both Halion (39863, clone is 40142) and Baltharus the Warborn (39751, clone is 39899) and everything is now working as intended. I also tested some other summoning situations (Putricide's Trap, 38879) and it did NOT break situations where the creature is just summoned, but not cloned.

I updated .ab creaturestat so that it will show if a creature is a clone, a summon with a summoner, or a summon without a summoner.

Please test Halion with this latest version and see if the issue is resolved. I'd also appreciate you thinking about any other situation that uses a similar cloning mechanic that we can test.

Thank you for testing!

WangDianhui · 2023-10-17T02:30:00Z

Please test Halion with this latest version and see if the issue is resolved. I'd also appreciate you thinking about any other situation that uses a similar cloning mechanic that we can test.

Halion now acts without problem in our 5-man party fight. Then I tested some more bosses with linked hp:
Dark council in Black Temple: no issue

Twin Emperor in Ahn'Qiraj: The source of cloned damage is boss itself... So an unintented modifier is applied to it

wrong damage:

right damage:

Twin Val'kyr in TOC: Very strange, their hp is correctly modified when spawned, but will fall to 1 immediately when contacted. And there is no damage log in console.

kjack9 · 2023-10-17T02:44:35Z

Twin Emperor in Ahn'Qiraj: The source of cloned damage is boss itself... So an unintented modifier is applied to it

Unless I misunderstand (EDIT: turns out I do) , I think it is working as it should. I'm not super familiar with the fight, so correct me if I'm wrong.The boss' damage to itself SHOULD be scaled, right? Otherwise you'd run into a situation where the boss hits itself for the original value (3837) even though his health is drastically reduced. The intention isn't to make the fight go faster - it's to make it feel about the same no matter how many players you have. So unless I'm missing something I think this is Working as Intended.

EDIT: Duh, I see now. That's the spell that ensures their health stays in-sync. I think a spell blacklist is probably called for here.

Twin Val'kyr in TOC: Very strange, their hp is correctly modified when spawned, but will fall to 1 immediately when contacted. And there is no damage log in console.

I will investigate this!

- spells with SPELL_AURA_SHARE_DAMAGE_PCT effects will now correctly be unmodified - added `spellIdsToNeverModify` and correctly skip modification of them - add "Twin Empathy" (1177) to the `spellIdsToNeverModify` list - convert `_IsAuraPercentDamage` to `_isAuraWithEffectType` since this probably isn't the last I'll need it - logging changes, naturally

kjack9 · 2023-10-17T07:29:09Z

@WangDianhui

Twin Emps fixed in e3a9f80 with a better permanent fix proposed to AC core in azerothcore/azerothcore-wotlk#17532 .

I now have a mechanism by which I can list SpellIDs that should never be modified. I expect this probably isn't the last time we'll need it.

Twin Val'kyr is up next. So far I can replicate exactly what you're describing - scaling looks great until they're engaged then they drop to 1 health. Disabling AutoBalance globally (without recompiling it out) fixes the issue.

I classify the issue as "super weird". More to come.

…tLevel

kjack9 · 2023-10-18T04:35:57Z

@WangDianhui

BAM! Fixed Twin Val'kyr by moving the initial stat scaling to earlier in the creature creation process. The boss script was getting very confused about how much max health the Val'kyr had. Now I alter it before it (or any other boss script) sees the creature.

What else you got?!? 😄

…don't work well in module config

WangDianhui · 2023-10-19T11:54:27Z

What else you got?!? 😄

I've played through ICC, TOC, ULD, NAXX, Eyes and many other dungeons, didn't find any problems.

Really a fantastic job!

kjack9 added 30 commits September 26, 2023 00:32

Only skip critters that are flavor-only (<= level 5)

6c6a51b

Refactor to break out some logic into separate functions.

d9e37bb

Refactor more repeated operations into separate functions

327cfe3

- Add worldHealthMultiplier, intended to be used to scale the health of attackable game objects in the instance

Continued refinement of non-creature-based damage and healing

a425a83

World damage scaling is working, WIP

02ee071

- need to apply statmodifiers still - improved logging

Further work on summoned creatures, still WIP

64975cd

- removed unnecessary `std::string`s

WIP

fee7e9a

Optimize map updates to only occur when necessary. WIP.

17d003b

Create documentation for Info classes, add player lists

f10afea

Reworking config tracking, WIP

eeb500b

Recount players on a config reload.

5eca60d

Improve player enter/leave behavior.

46737ea

Improve handling of empty instances, properly scale trigger creatures…

85f5811

…, improve `.ab mapstat`

Check that the target for .ab creaturestat is in a dungeon.

ef5fa03

Move boss detection to separate function

5d22b57

- boss summons now also count as a "boss"

Do not modify spells that hurt the player but are intended to - Dark …

1ca9bee

…Runes, etc - logging improvements

Fix world multipliers not getting reloaded. Logging improvements.

e636e36

Additional debug for boss detection

070cdcd

World multipliers now honor stat modifiers

7494c4c

- logging improvements

Re-enable the processing of map stats when the instance is empty

746e1fb

Combat locking: WIP

211b05b

Combat locking - better implementation. WIP, needs notifications.

fbc8eeb

Re-implement combat locking

6de3e83

Complete migration from skipMe to isCreatureRelevant

40f8f17

Fix enemy totems not level scaling. Update logging statement.

0df570a

Resolve issue with heroic dungeons that don't have LFG levels defined

e3e3d0e

kjack9 added 3 commits October 15, 2023 03:14

Fix dungeon difficulty normal, add error logging if no LFG found

39257dc

Fix incorrect heroic settings.

2a0c1b0

- fix display issue with active creatures

Fix syntax error.

47fc321

- that'll teach me to commit before I build

Handle cloned summons, improve creaturestat command

2b4e2aa

- track summoner as a part of AutoBalanceCreatureInfo - detect when a summon is a clone and use the correct current health instead of scaling again - add summon information to `.ab creaturestat` - as always, logging improvements

Move initial scaling from first OnAllCreatureUpdate to Creature_Selec…

447a3d8

…tLevel

kjack9 added 4 commits October 18, 2023 01:18

Tell user to move logging settings to worldserver.conf, since they …

660cfbf

…don't work well in module config

Fix combat locking.

58ca271

Small update to spellIdsToNeverModify

f898e74

Move warning to debug.

3f06fda

Helias approved these changes Oct 19, 2023

View reviewed changes

Helias merged commit 50a5d5e into azerothcore:master Oct 19, 2023
1 check passed

kjack9 mentioned this pull request Oct 21, 2023

Trial of the crusader: faction champions' stats are not scaled down #144

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

World damage/healing, destructible buildings, multiplier rewrite, logging improvements #157

World damage/healing, destructible buildings, multiplier rewrite, logging improvements #157

kjack9 commented Oct 12, 2023 •

edited

Loading

kjack9 commented Oct 13, 2023 •

edited

Loading

pangolp commented Oct 13, 2023

kjack9 commented Oct 14, 2023

kjack9 commented Oct 14, 2023 •

edited

Loading

WangDianhui commented Oct 14, 2023

kjack9 commented Oct 14, 2023 •

edited

Loading

kjack9 commented Oct 14, 2023 •

edited

Loading

WangDianhui commented Oct 15, 2023

kjack9 commented Oct 15, 2023 •

edited

Loading

kjack9 commented Oct 16, 2023 •

edited

Loading

WangDianhui commented Oct 17, 2023

kjack9 commented Oct 17, 2023 •

edited

Loading

kjack9 commented Oct 17, 2023 •

edited

Loading

kjack9 commented Oct 18, 2023

WangDianhui commented Oct 19, 2023

World damage/healing, destructible buildings, multiplier rewrite, logging improvements #157

World damage/healing, destructible buildings, multiplier rewrite, logging improvements #157

Conversation

kjack9 commented Oct 12, 2023 • edited Loading

Changes Proposed:

Issues Addressed:

SOURCE:

Tests Performed:

Known Issues and TODO List

How to Test the Changes:

kjack9 commented Oct 13, 2023 • edited Loading

pangolp commented Oct 13, 2023

kjack9 commented Oct 14, 2023

kjack9 commented Oct 14, 2023 • edited Loading

WangDianhui commented Oct 14, 2023

kjack9 commented Oct 14, 2023 • edited Loading

kjack9 commented Oct 14, 2023 • edited Loading

WangDianhui commented Oct 15, 2023

kjack9 commented Oct 15, 2023 • edited Loading

kjack9 commented Oct 16, 2023 • edited Loading

WangDianhui commented Oct 17, 2023

kjack9 commented Oct 17, 2023 • edited Loading

kjack9 commented Oct 17, 2023 • edited Loading

kjack9 commented Oct 18, 2023

WangDianhui commented Oct 19, 2023

kjack9 commented Oct 12, 2023 •

edited

Loading

kjack9 commented Oct 13, 2023 •

edited

Loading

kjack9 commented Oct 14, 2023 •

edited

Loading

kjack9 commented Oct 14, 2023 •

edited

Loading

kjack9 commented Oct 14, 2023 •

edited

Loading

kjack9 commented Oct 15, 2023 •

edited

Loading

kjack9 commented Oct 16, 2023 •

edited

Loading

kjack9 commented Oct 17, 2023 •

edited

Loading

kjack9 commented Oct 17, 2023 •

edited

Loading