Feat(Conf): Rename configuration file to match module name #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Eluna Module Updates: Lua Version and Static Linking Support Recent updates to the **Eluna** module in **AzerothCore** introduce new configuration options to manage Lua versions and static linking: - **`-DLUA_VERSION=luajit/lua52/lua53/lua54`**: Select the Lua version for the module, supporting LuaJIT, Lua 5.2, 5.3, or 5.4. - **`-DLUA_STATIC=on/off`**: Configure whether Lua should be linked statically or dynamically. These options allow flexible Lua integration, building on Eluna's existing capabilities to handle different Lua versions. The changes also improve compatibility and performance by enabling static linking where needed. #### Integration with Eluna This functionality extends Eluna's existing support for Lua compatibility, mainly in **ElunaCompat.cpp**, which handles Lua version-specific interactions. These updates enhance Eluna’s adaptability for various Lua configurations in **AzerothCore**.
It's just a QoL update, all modules have a conf linked to their name, but Eluna has a conf called mod_LuaEngine, so I think it's a good idea to rename it to mod_eluna.
55Honey
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just a QoL update, all modules have a conf linked to their name, but Eluna has a conf called mod_LuaEngine, so I think it's a good idea to rename it to mod_eluna.