Fix build, crash, etc. #23
Conversation
anzz1
commented
Jan 10, 2022
anzz1
commented
- Replaced deprecated config api to fix build
- Fix crash when NumPhrases = 0
- Add option to enable/disable
- Add visual effect for successful enchantment
* Replaced deprecated config api to fix build * Fix crash when NumPhrases = 0 * Add option to enable/disable * Add visual effect for successful enchantment
|
Great @Helias, you are full with the modules. 😀😀😀 |
some weekends I check the modules and I update them hehe, I put all the reusable-workflows ci in all modules |
Brilliant. I had updated several of them more than 6 months ago. But perhaps, some of them were left without updating. |
|
Regarding the pull request. I would delete the commented line or, failing that, I would create a configuration, for those who want to enable it. I think the second option is better, and let everyone decide if they want to do it or not. Therefore, if you want, once the pull request is approved, I can make the change, or if you want to do so, you can include it right here. |
you could do it in a separate PR, in this PR I am trying to finish fixing the build so that at least it compiles and someone can use it in a way |
Perfect, we'll do it in another pull request then. |
|
You will have to correct the SQL path. Afterwards, you have to explain to me how to edit someone else's pull request, because it is not clear to me what steps I have to do. I think I have permissions to do it, but in this case, if I wanted to edit the path, I wouldn't know how to do it. Unless you create another pull request, merge it, and then update the branch, but I figure there must be another way to do it. |
|
My goodness, it was difficult for me but I think I understood how it is. 😄😄😄 |
|
PR merged, thanks you both! |
