Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore. update api and module #25

Merged
merged 2 commits into from
Mar 12, 2024
Merged

chore. update api and module #25

merged 2 commits into from
Mar 12, 2024

Conversation

pangolp
Copy link

@pangolp pangolp commented Mar 12, 2024 •
edited
Loading

  1. Add the issue template
  2. Add the pull request template
  3. Move the README to the .github folder
  4. Add the file random_enchants.h
  5. Rewrite the random_enchants.cpp file
  6. Make sure the getRandEnchantment method returns a value [[nodiscard]]
  7. Use camel case convention

@pangolp pangolp marked this pull request as ready for review March 12, 2024 14:23
@pangolp pangolp merged commit 7e0a09d into azerothcore:master Mar 12, 2024
1 check passed
@pangolp pangolp deleted the update branch March 12, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open Vanilla item crash I want to get the Chinese name of the item, how should I change it?
1 participant
@pangolp