Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add null-check for target var in transmog_scripts.cpp #137

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

Helias
Copy link
Member

@Helias Helias commented Oct 8, 2023

checking this crash log https://gist.github.com/assada/068435b470644a1b9a98d94b61a056d3
it seems that the target variable is 0x0 as value, this could make the crash but I am not sure 100%, so please, test this PR.

closes #112
closes #135

@Nyeriah Nyeriah merged commit 97eb89b into master Oct 8, 2023
1 check passed
@Helias Helias deleted the prevent-crash branch October 8, 2023 14:44
@svenbledt
Copy link
Contributor

Amazing thank you very much ;) that worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with custom Races Crash
3 participants