feat: add sorting feature and related conf

[Helias]

closes #133

I tested it in-game with few items

[Nyeriah]

@Ceikry

[Nyeriah]

This query will perform very badly with this cross-db join

[Helias]

I know, I do not know how to improve it
would be better to convert it into a left join?

[Ceikry]

Couldn't you just sort the generated vector of allowed items instead? Sure you sort multiple times but it's a cheap sort on such a small collection and wouldn't be nearly as messy.

something like this (you can and should probably make the name comparison better)

bool CmpTmog (Item* i1, Item* i2)
{
    const ItemTemplate* i1t = i1->GetTemplate();
    const ItemTemplate* i2t = i2->GetTemplate();
    return i1t->Name1[0] > i2t->Name1[0] || i1t->Quality > i2t->Quality;
}

    sort(allowedItems.begin(), allowedItems.end(), CmpTmog);

[Ceikry]

Couldn't you just sort the generated vector of allowed items instead? Sure you sort multiple times but it's a cheap sort on such a small collection and wouldn't be nearly as messy.

something like this (you can and should probably make the name comparison better)

bool CmpTmog (Item* i1, Item* i2)
{
    const ItemTemplate* i1t = i1->GetTemplate();
    const ItemTemplate* i2t = i2->GetTemplate();
    return i1t->Name1[0] > i2t->Name1[0] || i1t->Quality > i2t->Quality;
}

    sort(allowedItems.begin(), allowedItems.end(), CmpTmog);

in fact I would advise mildly reworking this to use string::compare for the name comparisons.

[Helias]

I will try that, thank you!

[Helias]

I restored the code as it was before and added that sort(allowedItems.begin(), allowedItems.end(), CmpTmog); before return allowedItems but it seems not working

[Helias]

if I remove i1t->Quality > i2t->Quality it orders the items per name, so I think that in some way I could sort them, I will look better into this, thanks a lot for the input

[Ceikry]

Yeah you might have to tweak the conditions for the comparison to be a bit more intelligent, I just kinda slapped an example together from what I remembered about C++ sorting

[Helias]

now it works

[Nyeriah]

Way much better, good job! 👍

[Helias]

thanks you both!