Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MySQL docs #1023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update MySQL docs #1023

wants to merge 1 commit into from

Conversation

yoursw
Copy link

@yoursw yoursw commented Nov 11, 2024

Description

  • Adds robustness to the docs so that they are less likely to become outdated.
  • Adds GPG check for MySQL apt config.
  • Fixes minor spelling issues.

Thank you.

aradep
aradep reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@aradep aradep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For the quickstart debian12 guide though, could you omit the explanation text and condense everything into one code block for easier copy/pasting?

docs/debian12-install-guide.md
sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server libmysqlclient-dev
```

1. Harden installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this step. Noninteractive install of mysql sets root to socket authentication (no password) which leads to an error at the root password part of mysql_secure_installation.

docs/debian12-install-guide.md
@@ -80,6 +110,7 @@ sudo mysql_secure_installation
- Disallow root login remotely: Y
- Remove test database: Y
- Reload privilege tables: Y

### Setup SQL Database
```bash
sudo mysql -u root -p
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to just sudo mysql and remove instruction to enter password. (same here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aradep aradep aradep left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoursw @aradep