chore: update missing boolean fields #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PatrickMenoti
commented
Jan 10, 2025
•
PatrickMenoti
commented
- Boolean fields that need PATCH after POST (some were missing)
- Fix: sending empty CNAMES list caused inconsistency in terraform state
- Removal of legacy fields
- Update testing workflow
guiafonso-ol
previously approved these changes
Jan 10, 2025
pablodiehl
previously approved these changes
Jan 13, 2025
helio-neto
approved these changes
Jan 13, 2025
PatrickMenoti
dismissed stale reviews from pablodiehl and guiafonso-ol
via
0ebb2d5
pablodiehl
approved these changes
Jan 14, 2025
guiafonso-ol
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.