Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interruption: Provide better feedback on CLI #173

Merged
merged 31 commits into from
Jan 4, 2024

Conversation

azriel91
Copy link
Owner

@azriel91 azriel91 commented Jan 3, 2024

Closes #172.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (1ee4384) 93.46% compared to head (e32681a) 93.39%.

Files Patch % Lines
crate/rt_model_native/src/output/cli_output.rs 15.00% 17 Missing ⚠️
crate/cmd_rt/src/progress.rs 91.37% 10 Missing ⚠️
crate/core/src/progress/progress_sender.rs 74.28% 9 Missing ⚠️
crate/cmd_rt/src/cmd_execution.rs 98.00% 1 Missing ⚠️
...src/cmd_blocks/apply_state_sync_check_cmd_block.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   93.46%   93.39%   -0.07%     
==========================================
  Files         407      408       +1     
  Lines       41453    41681     +228     
==========================================
+ Hits        38742    38930     +188     
- Misses       2711     2751      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 merged commit b2a3eaf into main Jan 4, 2024
13 checks passed
@azriel91 azriel91 deleted the feature/172/cli-interrupt-feedback branch January 4, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CliOutput interrupt feedback
1 participant