Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group type parameters into CmdCtxTypes. #177

Merged
merged 67 commits into from
Jan 28, 2024
Merged

Group type parameters into CmdCtxTypes. #177

merged 67 commits into from
Jan 28, 2024

Conversation

azriel91
Copy link
Owner

Closes #166.

azriel91 added 30 commits January 11, 2024 16:56
@azriel91
Add CmdCtxTypeParams trait.
92c0510
@azriel91
Add value_traits crate with AppError trait.
095ec58
@azriel91
Add CmdCtxTypeParamsConstrained.
9398f60
@azriel91
Use single ParamsKeys type instead of flattening it for now.
195e062
@azriel91
Do a string find/replace for type parameters with CmdCtxTypeParams.
203cdf7 
Commands:

```bash
sd -s "E, PKeys" "CmdCtxTypeParamsT" $(fd -Ftf '.rs')
sd -s "E, O, PKeys" "CmdCtxTypeParamsT" $(fd -Ftf '.rs')
sd -s "&'ctx mut O" "&'ctx mut CmdCtxTypeParamsT::Output" $(fd -Ftf '.rs')
sd -s '&mut O' '&mut CmdCtxTypeParamsT::Output' $(fd -Ftf '.rs')
sd -s 'Flow<E>' 'Flow<CmdCtxTypeParamsT::AppError>' $(fd -Ftf '.rs')
sd -s 'ParamsTypeRegs<PKeys>' 'ParamsTypeRegs<CmdCtxTypeParamsT::ParamsKeys>' $(fd -Ftf '.rs')
sd -s 'Error = CmdCtxTypeParamsT = PKeys' 'CmdCtxTypeParamsT' $(fd -Ftf '.rs')
sd -s "E, PKeys" "CmdCtxTypeParamsT" $(fd -Ftf '.rs')
grs -- examples crate/rt_model/src/flow.rs crate/rt_model_core/src/params/params_type_regs.rs
sd -s "E, O>" "CmdCtxTypeParamsT>" $(fd -Ftf '.rs')
cargo fmt --all
```
@azriel91
Add Scope type param to CmdCtxTypeParams.
9256899
@azriel91
Add supertrait constrait on CmdCtxTypeParamsConstrained.
8f221d0
@azriel91
Add CmdCtxTypeParamsConstrained blanket implementation for `T: CmdC…
881cd26 
…txTypeParams`.
@azriel91
Fix *_params methods in SingleProfileSingleFlow.
0e33ca3
@azriel91
Replace &'view mut O with &'view mut CmdCtxTypeParamsT::Output.
68ef039
@azriel91
Fix type reference to *ParamsKey in SingleProfileSingleFlow scope.
f6f1485
@azriel91
Fix type parameters in all scopes.
3409246
@azriel91
Fix type parameters in CmdCtx and CmdCtxBuilder.
e7da1c8
@azriel91
Fix E type parameter in FlowSelection.
9fa0bc7
@azriel91
Add CmdCtxBuilderTypeParams and use it in scope_struct.rs.
6ef67af
@azriel91
Remove marker field from scope struct builders.
140b43f
@azriel91
Update impl_with_param to use CmdCtxBuilderTypeParamsT.
aaa90e2
@azriel91
Temporarily disable with_param_key_unknown tokens.
0eb8bf5
@azriel91
Update impl_with_profile to use CmdCtxBuilderTypeParamsT.
9fc0757
@azriel91
Update struct_definition.rs to use CmdCtxBuilderTypeParamsT.
0776bb5
@azriel91
Update impl_with_profile_filter.rs to use CmdCtxBuilderTypeParamsT.
47ab902
@azriel91
Update impl_with_flow.rs to use CmdCtxBuilderTypeParamsT.
5d42cd7
@azriel91
Update impl_constructor.rs to use CmdCtxBuilderTypeParamsCollector.
070fccb
@azriel91
Update impl_common_fns.rs to use CmdCtxBuilderTypeParamsT.
157fdc6
@azriel91
Extract common functions to with_param.rs.
9793a9e
@azriel91
Update impl_with_params_k to use CmdCtxBuilderTypeParamsT.
bdc4ca4
@azriel91
Remove unused functions.
d2a2573
@azriel91
Implement CmdCtxBuilderTypeParams for `CmdCtxBuilderTypeParamsColle…
121eb70 
…ctor`.
@azriel91
Adjust trait bounds on ParamsKeys and CmdCtxBuilderTypeParams.
287c30b
@azriel91
Remove Scope associated type from CmdCtxTypeParams.
b9889b6
azriel91 added 25 commits January 21, 2024 11:03
@azriel91
Add ImplHeaderBuilder.
c6dac82
@azriel91
Rename CmdCtxBuilderTypeBuilder::with_*_params_k to *_maybe.
d62872e
@azriel91
Update all impl_*.rs to use CmdCtxBuilderTypeParamsCollector.
9d409e5
@azriel91
Reduce constraints on initializing a scope builder.
29d7c42
@azriel91
Update *CmdBlocks and *Cmds to use CmdCtxTypeParamsT.
34477cd
@azriel91
Correctly implement impl_params_deserialize.
f497da9
@azriel91
Swap order of AppError and Output type parameters.
87ab5d2
@azriel91
Fix a lot of code_gen to do with multi profile scopes.
7f672f6
@azriel91
Update workspace_tests to use PeaceCmdCtxTypeParams.
9e94b9c
@azriel91
Reduce 'static constraint on OutputWrite.
fda6efd
@azriel91
Fix type parameter bounds when "output_progress" is enabled.
e2f9102
@azriel91
Try fix CmdCtxTypeParams lifetime issue with split `CmdCtxTypeParam…
cb6c8f9 
…s` within `CmdBlock` trait.
@azriel91
Revert "Try fix CmdCtxTypeParams lifetime issue with split `CmdCtxT…
84681c8 
…ypeParams` within `CmdBlock` trait."

This reverts commit 68e663f8969917ce118432e6c3fef9a99becad61.
@azriel91
Add 'ctx bound to CmdCtxTypeParams in CmdExecution* types.
2ec16cf
@azriel91
Propagate 'ctx lifetime through *Cmds.
703c85e
@azriel91
Correctly restrict CmdCtxTypeParams' lifetime.
56c48f7
@azriel91
Update debug test assertions to use PeaceCmdCtxTypeParams.
88ca35e
@azriel91
Fix params_map population for no / single profile scopes.
a8f9b20
@azriel91
Fix profile_to_profile/flow_params scope builder value.
8b3ad3d
@azriel91
Address clippy lints.
9e0fcc6
@azriel91
Rename CmdCtxTypeParams to CmdCtxTypes.
99482b5
@azriel91
Add more trait bounds on OutputWrite.
c53e191
@azriel91
Update envman to use CmdCtxTypes type parameter.
f7e41cb
@azriel91
Update download to use CmdCtxTypes type parameter.
266d3cd
@azriel91
Update CHANGELOG.md.
1359a28
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2024 •
edited
Loading

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (47e4871) 93.40% compared to head (4db241a) 93.29%.

Files Patch % Lines
crate/code_gen/src/cmd/type_params_selection.rs 88.88% 8 Missing ⚠️
...md/src/scopes/type_params/flow_params_selection.rs 0.00% 6 Missing ⚠️
...src/scopes/type_params/profile_params_selection.rs 0.00% 6 Missing ⚠️
...src/cmd_blocks/apply_state_sync_check_cmd_block.rs 82.14% 5 Missing ⚠️
crate/cmd/src/scopes/single_profile_no_flow.rs 69.23% 4 Missing ⚠️
crate/cmd/src/scopes/no_profile_no_flow.rs 66.66% 3 Missing ⚠️
...c/scopes/type_params/workspace_params_selection.rs 0.00% 3 Missing ⚠️
crate/code_gen/src/cmd/impl_build.rs 97.88% 3 Missing ⚠️
crate/cmd/src/scopes/single_profile_single_flow.rs 90.47% 2 Missing ⚠️
crate/code_gen/src/cmd/impl_header_builder.rs 99.02% 2 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   93.40%   93.29%   -0.11%     
==========================================
  Files         408      394      -14     
  Lines       41690    40234    -1456     
==========================================
- Hits        38939    37535    -1404     
+ Misses       2751     2699      -52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 merged commit 87622fd into main Jan 28, 2024
13 checks passed
@azriel91 azriel91 deleted the feature/166/type-parameter-revamp branch January 28, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type Parameter Revamp / Simplification
1 participant
@azriel91