Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TS type param and hard code it to SetUp. #180

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

azriel91
Copy link
Owner

Closes #179.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (433252d) 93.71% compared to head (23cb73c) 93.85%.
Report is 8 commits behind head on main.

Files Patch % Lines
...src/cmd_blocks/apply_state_sync_check_cmd_block.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   93.71%   93.85%   +0.14%     
==========================================
  Files         407      407              
  Lines       41400    41320      -80     
==========================================
- Hits        38796    38780      -16     
+ Misses       2604     2540      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 merged commit 3683183 into main Jan 30, 2024
13 checks passed
@azriel91 azriel91 deleted the feature/179/remove-resources-type-state-type-param branch January 30, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Resources' type state parameter from Scopes
1 participant