This repository has been archived by the owner on Aug 18, 2022. It is now read-only.
Switch custom actions to being a single file #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect of the work on #109 and #122 it has been decided to change the design of custom actions
Instead of a directory containing multiple YAML files, a single YAML file is used. This simplifies the code significantly, it is also felt this will give an easier/better user experience also.
The file used resides in the
$HOME/.rover/
directory and is namedactions.yaml
.When rover starts this file is checked, if it doesn't exist a default is created, see pkg/custom/default_actions.yaml Note: The contents of this default file are embedded into the rover binary at build time
Example of actions.yaml
Note there is no longer a need for a
name:
field, the YAML key is used as the action nameAll other functionality remains the same