Improve End User experience with Deploy to Azure button and DNS zone params #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameters were added for existingDnsZones and dnsZoneNames but with no default value. When utilizing the "Deploy to Azure" workflow these fields are required to be completed but it is unclear what values should be there as a baseline to users who aren't familiar. Adding in the defaults simplifies the process while still allowing modifications if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters were added for existingDnsZones and dnsZoneNames but with no default value. When utilizing the "Deploy to Azure" workflow these fields are required to be completed but it is unclear what values should be there as a baseline to users who aren't familiar. Adding in the defaults simplifies the process while still allowing modifications if necessary.