Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure-rest/azure-apicenter-rest] Spec changes for tool testing #10978

Conversation

azure-sdk
Copy link
Owner

Create to sync test-repo-billy/azure-rest-api-specs#3421

This pull request has been automatically generated for preview purposes.

topshot99 and others added 27 commits August 1, 2024 08:08
### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
This PR adds support for MakeList and MakeSet aggregates. Changes are
based on PR:

https://github.com/Azure/azure-cosmos-dotnet-v3/pull/4490/files#diff-f5144c66029f18b314e4895030a98d36fbb2323877f035a7edbcd9415e8b89f3

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_
Yes, but currently they are skipped as feature is not supported by the
latest public emulator.

### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <[email protected]>
Azure#30503)

### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
- This PR removes the support of float 16 from vector embedding data
type
- This PR adds support to block `nonStreamingOrderBy` queries which do
not have a TOP or LIMIT+OFFSET present in the query. This check can be
disabled by using `allowUnboundedNonStreamingQueries` flag in options.

- An additional check is placed for internal buffer size. If calculated
buffer size is greater than the default buffer size, an error is thrown.
This is done as a safeguard from excessive memory consumption. Max
buffer size can be increased using `vectorSearchBufferSize` in the
options.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_
Yes

### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
)

### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
This PR fixes the partition key format for bulk delete, patch, and read
operations. Due to wrong partition key format, these operations were
failing in bulk operations.
It also manages the partition key format in batch operations for
non-partitioned containers or containers without a predefined partition
key.


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_
yes

### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Aditishree . <[email protected]>
### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR

### Describe the problem that is addressed by this PR
This PR updates the example in documentation for connection policy and
cosmos client.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Aditishree . <[email protected]>
### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
This PR generates v4 samples and removes v4 features from v3 sample
folder.


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Aditishree . <[email protected]>
Now that the product issue is fixed and released in identity, we no
longer needs
this workaround. This PR removes it.
…to v2 (Azure#30600)

- upgrade for app-configuration

- upgrade for ai-language-conversations

- upgrade for container-registry

- upgrade for event hubs checkpoint stores

- upgrade for mock-hub
### Packages impacted by this PR

@azure/identity

### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

In order to improve the error experience for Managed Identity we want to
do a few things:

1. Remove misleading error messages like authority_not_found for any 400
2. Display the error's cause / InnerException / etc. 
3. Provide helpful debugging information in the exception message

(1) and (2) are done here, (3) is still in flux as I need to think about
what information will be helpful without being overwhelming.

### Are there test cases added in this PR? _(If not, why?)_

Printing out the error's cause is an implementation detail of the
runtime and _not_ something that gets stringified

Co-authored-by: Christopher Scott <[email protected]>
Focuses on cleaning up the perf libs folder by removing outdated and
redundant performance tests for various packages under the service-bus
directory. The changes are as follows:

- `azure-sb` 
- The package has been deprecated and is no longer in active use.
Therefore, maintaining performance tests for this package is
unnecessary.
- `@azure/[email protected]` 
- this version has the perf tests under
`sdk/servicebus/service-bus/perf-tests/` folder
- `@azure/[email protected]` 
- this version has seen a significant decline in usage has less than
2.5% of the downloads (in the past 7 days) compared to
`@azure/[email protected]`, making it insignificant to maintain
- `rhea-promise` tests 
- `rhea-promise` package are also being removed. However, if there is a
future need to compare benchmarks, we can reintroduce rhea-promise tests
under the `sdk/servicebus/service-bus/perf-tests/` folder.

This helps to streamline our perf tests, reduce maintenance overhead,
and ensure that our focus remains on the most relevant and actively used
packages.
<p dir="auto">Post release automated changes for azure-core-util</p>
…30596)

and fix code.

-------

### Packages impacted by this PR
`@azure/keyvault-*`
…zure#30613)

- update monitor-ingestion test code to adapt to the change

-------

### Packages impacted by this PR

monitor-ingestion mixed-reality-remote-rendering synapse-artifacts
maps-common
…e#30608)

### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR

### Describe the problem that is addressed by this PR
This PR fixes the issue where the correlatedActivityId argument was
mistakenly being mapped with another argument.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Aditishree . <[email protected]>
If we have an email from who requested the build we should use that for
both owners and approvers.
### Packages impacted by this PR
@azure/eventhubs-checkpointstore-blob

### Issues associated with this PR

N/A

### Describe the problem that is addressed by this PR

- migrates to use TSHY and vitest
- uses storage endpoint instead of storage connection string in the
tests
- enables browser testing
- updates test-resources.json accordingly
- fixes a behavior where an error is being wrapped in another

Live tests run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4018408&view=results

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

N/A

### Are there test cases added in this PR? _(If not, why?)_

N/A

### Provide a list of related PRs _(if any)_

N/A

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
…zure#29806)

- fix compilation errors.
- fix v1-beta samples targeting version
- update tests
deletes outdated files from the service directory.
### Packages impacted by this PR
@Azure/communication-chat 

### Describe the problem that is addressed by this PR

- Update the dependency @azure/communication-signaling package version
to fix the regressions in real time notification support in React
Native.
- 
- Update the dependency @azure/core-rest-pipeline package version to fix
the regressions in client response support in React Native.


### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
- migrates mockhub to TSHY and vitest
- stubs a test suite
- add a review folder
- migrates samples to be published by dev-tool

/cc @HarshaNalluru
They now reference the environment variable created by the arm template.
@azure-sdk azure-sdk force-pushed the sdkAuto/3421/@azure-rest_azure-apicenter-rest branch from 370ea81 to 8c642d6 Compare August 5, 2024 09:44
### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR

- On a partition error gone error in bulk calls, `substatus` in the
error needs to be checked instead of `subStatusCode`.
- Update ChangeLog with just the split proof support in bulk API.
Currently our SDK as a whole does not support merge.



### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
@azure-sdk azure-sdk force-pushed the sdkAuto/3421/@azure-rest_azure-apicenter-rest branch from 8c642d6 to 2bc2ffd Compare August 5, 2024 10:32
wanlwanl and others added 27 commits August 6, 2024 11:02
### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
Previously, pre-split epk range headers were getting discarded during
calculation of post-split over-lapping ranges. This was leading to
fetching of changefeed of entire partition instead of just the range
headers. Now, epk-range headers are being used to calculate the new
overlapping ranges.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
This PR updates changelog samples related to vector search feature

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <[email protected]>
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

Co-authored-by: Manik Khandelwal <[email protected]>
fixes typo


### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
This PR enables linting for quantum-jobs package by

- removes the "-f html -o... || exit 0" part from `lint` NPM script
- removes `src` from linting because it is auto-generated
- fixes linter errors in test files
…zure#30632)

and fix code

-------

### Packages impacted by this PR
ai-form-recognizer, ai-text-analytics, web-pubsub-client
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#8760 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
This PR

- removes `-f html -o telemetry-exporter-lintReport.html || exit 0` from
`lint` NPM script
- updates eslint config to report warn for some rules
- applies result of `lint:fix`
- fixes/suppresses linting errors
- in analyze pipeline, changes to build packages before linting so that
linting with types works

### Packages impacted by this PR

monitor-opentelemetry-exporter

### Issues associated with this PR

Azure#17942
### Packages impacted by this PR
- @azure-rest/maps-search
- @azure-rest/maps-route
- @azure-rest/maps-render
- @azure-rest/maps-geolocation

### Issues associated with this PR
Azure#29699 

### Describe the problem that is addressed by this PR
1. Migrate the test to federated authentication
2. In the samples, use AAD auth as default authentication method.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
NA


### Are there test cases added in this PR? _(If not, why?)_
Yes, changes are made in the `Maps<serviceName>.spec.ts`. Note that
there are some failed pipelines:
1. LRO test in maps-route-rest: Known issue. Maps team has an exist work
item under the internal backlog.
2. `CredentialUnavailableError` in macos environment under
maps-geolocation: Know issue. Azure#30356

### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
)

### Packages impacted by this PR
- @azure-rest/maps-search
- @azure-rest/maps-route
- @azure-rest/maps-render
- @azure-rest/maps-geolocation

### Issues associated with this PR
- Azure#30420 

### Describe the problem that is addressed by this PR
Update the changelog for changes in Azure#30420 

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Fix Azure#30463 by including
the portions of @azure/storage-blob required by
@azure/storage-file-datalake.


### Packages impacted by this PR

@azure/storage-file-datalake

### Issues associated with this PR

Azure#30463

### Describe the problem that is addressed by this PR

Imports are broken. The package is unusable.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

N/A

### Are there test cases added in this PR? _(If not, why?)_

No. No code has changed.

### Provide a list of related PRs _(if any)_

N/A

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

N/A

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
so that VS Code prettier extension can import it via the "prettier" key
in most of our packages' package.json:

```
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
```

### Packages impacted by this PR
eslint-plugin-azure-sdk
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#8754 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
…zure#30683)

### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Merge 6651cc7aa36b054765d54e0576c1fe371a1e5396 into 0bc7c1e79795562287755b516934c77fbc1e5759
@azure-sdk azure-sdk force-pushed the sdkAuto/3421/@azure-rest_azure-apicenter-rest branch from 2bc2ffd to 0903fbf Compare August 8, 2024 08:52
@azure-sdk azure-sdk closed this Aug 11, 2024
@azure-sdk azure-sdk deleted the sdkAuto/3421/@azure-rest_azure-apicenter-rest branch August 11, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.