Fix, Provider\Germany: Pentecost is not an official holiday - except in Brandenburg #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbett Your code is failing because of new PHP CS rules. Please run the following on your PR/branch: When all is without errors, please commit. Then it should be good! :) |
…in Brandenburg (see azuyalabs#100)
…in Brandenburg (see azuyalabs#100)
fbett
force-pushed
the
germany-pentecost-is-not-a-general-holiday
branch
from
8a9495c to
f5389cd
Compare
…in Brandenburg (see azuyalabs#100)
|
The PR is refreshed. |
stelgenhof
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Pentecost was originally removed from the list of general holidays in #100.
That's because pentecost is not an official holiday (until today) - except in Brandenburg.
I don't know why, it was added again in #225.
So i don't remove pentecost from the list of general holidays again, but it is generally marked as TYPE_OTHER.
Previous #334